Fix existing existing environment variable filter

klutchell · klutchell · commit 92f3586abc5d · 2024-12-26T12:12:34.000-05:00
This boolean was reversed when filtering existing variables,
so it consistently sent a POST request to existing vars.

Signed-off-by: Kyle Harding &lt;kyle@balena.io&gt;
diff --git a/lib/plugins/environments.js b/lib/plugins/environments.js
@@ -301,7 +301,7 @@ module.exports = class Environments extends Diffable {
         )
         if (existingVariable) {
           existingVariables = existingVariables.filter(
-            (_var) => _var.name !== variable.name
+            (_var) => _var.name === variable.name
           )
           if (existingVariable.value !== variable.value) {
             await this.github.request(

Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,7 @@ module.exports = class Environments extends Diffable {`
`301`	`301`	`)`
`302`	`302`	`if (existingVariable) {`
`303`	`303`	`existingVariables = existingVariables.filter(`
`304`		`- (_var) => _var.name !== variable.name`
	`304`	`+ (_var) => _var.name === variable.name`
`305`	`305`	`)`
`306`	`306`	`if (existingVariable.value !== variable.value) {`
`307`	`307`	`await this.github.request(`