fix: add missing nop param for full-sync (#733)

* fix: add missing noop param for full-sync

* refactor: rename noop to nop for consistency

---------

Co-authored-by: Yadhav Jayaraman <[email protected]>

Author: PendaGTP

full-sync.js

@@ -1,19 +1,28 @@
-const { createProbot } = require('probot')
 const appFn = require('./')
+const { FULL_SYNC_NOP } = require('./lib/env')
+const { createProbot } = require('probot')
+
+async function performFullSync (appFn, nop) {
+  const probot = createProbot()
+  probot.log.info(`Starting full sync with NOP=${nop}`)
 
-const probot = createProbot()
-probot.log.info('Starting full sync.')
-const app = appFn(probot, {})
-app.syncInstallation()
-  .then(settings => {
-    if (settings.errors.length > 0) {
+  try {
+    const app = appFn(probot, {})
+    const settings = await app.syncInstallation(nop)
+
+    if (settings.errors && settings.errors.length > 0) {
       probot.log.error('Errors occurred during full sync.')
       process.exit(1)
-    } else {
-      probot.log.info('Done with full sync.')
     }
-  })
-  .catch(error => {
+
+    probot.log.info('Full sync completed successfully.')
+  } catch (error) {
     process.stdout.write(`Unexpected error during full sync: ${error}\n`)
     process.exit(1)
-  })
+  }
+}
+
+performFullSync(appFn, FULL_SYNC_NOP).catch((error) => {
+  console.error('Fatal error during full sync:', error)
+  process.exit(1)
+})

index.js

@@ -230,7 +230,7 @@ module.exports = (robot, { getRouter }, Settings = require('./lib/settings')) =>
     }
   }
 
-  async function syncInstallation () {
+  async function syncInstallation (nop = false) {
     robot.log.trace('Fetching installations')
     const github = await robot.auth()
 
@@ -249,7 +249,7 @@ module.exports = (robot, { getRouter }, Settings = require('./lib/settings')) =>
         log: robot.log,
         repo: () => { return { repo: env.ADMIN_REPO, owner: installation.account.login } }
       }
-      return syncAllSettings(false, context)
+      return syncAllSettings(nop, context)
     }
     return null
   }

lib/env.js

@@ -5,5 +5,6 @@ module.exports = {
   DEPLOYMENT_CONFIG_FILE_PATH: process.env.DEPLOYMENT_CONFIG_FILE || 'deployment-settings.yml',
   CREATE_PR_COMMENT: process.env.CREATE_PR_COMMENT || 'true',
   CREATE_ERROR_ISSUE: process.env.CREATE_ERROR_ISSUE || 'true',
-  BLOCK_REPO_RENAME_BY_HUMAN: process.env.BLOCK_REPO_RENAME_BY_HUMAN || 'false'
+  BLOCK_REPO_RENAME_BY_HUMAN: process.env.BLOCK_REPO_RENAME_BY_HUMAN || 'false',
+  FULL_SYNC_NOP: process.env.FULL_SYNC_NOP === 'true'
 }

test/unit/lib/env.test.js

@@ -27,6 +27,11 @@ describe('env', () => {
       const CREATE_PR_COMMENT = envTest.CREATE_PR_COMMENT
       expect(CREATE_PR_COMMENT).toEqual('true')
     })
+
+    it('loads default FULL_SYNC_NOP if not passed', () => {
+      const FULL_SYNC_NOP = envTest.FULL_SYNC_NOP
+      expect(FULL_SYNC_NOP).toEqual(false)
+    })
   })
 
   describe('load override values', () => {
@@ -37,6 +42,7 @@ describe('env', () => {
       process.env.SETTINGS_FILE_PATH = 'safe-settings.yml'
       process.env.DEPLOYMENT_CONFIG_FILE = 'safe-settings-deployment.yml'
       process.env.CREATE_PR_COMMENT = 'false'
+      process.env.FULL_SYNC_NOP = false
     })
 
     it('loads override values if passed', () => {
@@ -51,6 +57,8 @@ describe('env', () => {
       expect(DEPLOYMENT_CONFIG_FILE_PATH).toEqual('safe-settings-deployment.yml')
       const CREATE_PR_COMMENT = envTest.CREATE_PR_COMMENT
       expect(CREATE_PR_COMMENT).toEqual('false')
+      const FULL_SYNC_NOP = envTest.FULL_SYNC_NOP
+      expect(FULL_SYNC_NOP).toEqual(false)
     })
   })
 })

test/unit/lib/plugins/branches.test.js

@@ -10,9 +10,9 @@ describe('Branches', () => {
   log.error = jest.fn()
 
   function configure (config) {
-    const noop = false
+    const nop = false
     const errors = []
-    return new Branches(noop, github, { owner: 'bkeepers', repo: 'test' }, config, log, errors)
+    return new Branches(nop, github, { owner: 'bkeepers', repo: 'test' }, config, log, errors)
   }
 
   beforeEach(() => {

test/unit/lib/plugins/repository.test.js

@@ -17,9 +17,9 @@ describe('Repository', () => {
   log.error = jest.fn()
 
   function configure (config) {
-    const noop = false
+    const nop = false
     const errors = []
-    return new Repository(noop, github, { owner: 'bkeepers', repo: 'test' }, config, 1, log, errors)
+    return new Repository(nop, github, { owner: 'bkeepers', repo: 'test' }, config, 1, log, errors)
   }
 
   describe('sync', () => {