How can I add an exclusion filter in the suborgs?

[justinmchase]

For example suppose I have a suborg file such as;

suborgrepos:
  - example-*

But I want it to match all repos except for ones such as example-*-test?

I tried this but it doesn't seem to work:

suborgrepos:
  - example-*
  - !example-*-test

I can't seem to find any documentation about support for exclusion globs. Is this supported? Am I doing it wrong?

[martinm82]

This would be really a great feature next to the exclude for teams and collaborators where include/exclude are supported.

[martinm82]

@decyjphr is this something we could easily add into the Glob class? There is some code already that checks the suborgrepo item whether it matches a regex: https://github.com/github/safe-settings/blob/main-enterprise/lib/settings.js#L267.

[justinmchase]

Uff, you're implementing glob yourself:
https://github.com/github/safe-settings/blob/main-enterprise/lib/glob.js

Consider using the glob package instead:
https://www.npmjs.com/package/glob

[decyjphr]

@martinm82 Yes, that could be done. Probably a trivial change.

@justinmchase I remember looking at that. I think that npm module is used to get a list of files using a Glob pattern. Our class is just a wrapper to do searches in a string for glob pattern-like matches. Probably a different name would have been better.

[justinmchase]

Yeah I suppose you're right, I haven't looked this up in a while but I guess glob uses minimatch internally for the glob filtering of files:

isaacs/node-glob#530 (comment)