Skip to content

Commit c5e0c18

Browse files
chore: address review feedback - remove comment and fix numbering
1 parent 856680e commit c5e0c18

File tree

2 files changed

+10
-13
lines changed

2 files changed

+10
-13
lines changed

.github/workflows/release.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,3 @@ jobs:
129129
sed -i "s/version = \".*\"/version = \"$PYTHON_VERSION\"/" pyproject.toml
130130
echo "Updated pyproject.toml version to $PYTHON_VERSION (for release artifacts only)"
131131
fi
132-
133-
# Note: No longer committing version changes back to main branch
134-
# The version is only updated in the release artifacts

CONTRIBUTING.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,23 +9,23 @@ Please note that this project is released with a [Contributor Code of Conduct](C
99
These are one time installations required to be able to test your changes locally as part of the pull request (PR) submission process.
1010

1111
1. Install [Python 3.11+](https://www.python.org/downloads/)
12-
2. Install [uv](https://docs.astral.sh/uv/) for package management
13-
3. Install [Git](https://git-scm.com/downloads)
14-
4. Have an AI coding agent available: [Claude Code](https://www.anthropic.com/claude-code), [GitHub Copilot](https://code.visualstudio.com/), [Gemini CLI](https://github.com/google-gemini/gemini-cli), or [Qwen Code](https://github.com/QwenLM/qwen-code). We're working on adding support for other agents as well.
12+
1. Install [uv](https://docs.astral.sh/uv/) for package management
13+
1. Install [Git](https://git-scm.com/downloads)
14+
1. Have an AI coding agent available: [Claude Code](https://www.anthropic.com/claude-code), [GitHub Copilot](https://code.visualstudio.com/), [Gemini CLI](https://github.com/google-gemini/gemini-cli), or [Qwen Code](https://github.com/QwenLM/qwen-code). We're working on adding support for other agents as well.
1515

1616
## Submitting a pull request
1717

1818
>[!NOTE]
1919
>If your pull request introduces a large change that materially impacts the work of the CLI or the rest of the repository (e.g., you're introducing new templates, arguments, or otherwise major changes), make sure that it was **discussed and agreed upon** by the project maintainers. Pull requests with large changes that did not have a prior conversation and agreement will be closed.
2020
2121
1. Fork and clone the repository
22-
2. Configure and install the dependencies: `uv sync`
23-
3. Make sure the CLI works on your machine: `uv run specify --help`
24-
4. Create a new branch: `git checkout -b my-branch-name`
25-
5. Make your change, add tests, and make sure everything still works
26-
6. Test the CLI functionality with a sample project if relevant
27-
7. Push to your fork and submit a pull request
28-
8. Wait for your pull request to be reviewed and merged.
22+
1. Configure and install the dependencies: `uv sync`
23+
1. Make sure the CLI works on your machine: `uv run specify --help`
24+
1. Create a new branch: `git checkout -b my-branch-name`
25+
1. Make your change, add tests, and make sure everything still works
26+
1. Test the CLI functionality with a sample project if relevant
27+
1. Push to your fork and submit a pull request
28+
1. Wait for your pull request to be reviewed and merged.
2929

3030
Here are a few things you can do that will increase the likelihood of your pull request being accepted:
3131

0 commit comments

Comments
 (0)