Merge pull request #434 from nohehf/fix/python-nested-function-declaration

fix/python nested function declaration

Author: Hendrik van Antwerpen

languages/tree-sitter-stack-graphs-python/src/stack-graphs.tsg

@@ -798,15 +798,21 @@ inherit .parent_module
   let @body.class_member_attr_scope = #null
 }
 
-(function_definition
-  parameters: (parameters
-    . (identifier) @param)
-  body: (block) @body)
+; method definition
+(class_definition
+    body: (block
+            (function_definition
+                parameters: 
+                    (parameters . (identifier) @first_param)
+                body: (block) @method_body
+            )
+         )
+) 
 {
-  edge @param.def -> @param.class_self_scope
-  edge @param.class_member_attr_scope -> @param.output
-  edge @param.output -> @body.after_scope
-  attr (@param.output) push_node = @param
+  edge @first_param.def -> @first_param.class_self_scope
+  edge @first_param.class_member_attr_scope -> @first_param.output
+  edge @first_param.output -> @method_body.after_scope
+  attr (@first_param.output) push_node = @first_param
 }
 
 [

languages/tree-sitter-stack-graphs-python/test/nested_functions.py

@@ -0,0 +1,6 @@
+def outer(a):
+    def inner(b):
+        pass
+
+    inner(1)
+    # ^ defined: 2

languages/tree-sitter-stack-graphs-python/test/not_a_method.py

@@ -0,0 +1,20 @@
+class Foo:
+    a = 1
+
+    def first_method(self):
+        self.a
+        #    ^ defined: 2
+
+    def second_method(self):
+        self.a
+        #    ^ defined: 2
+
+        # First argument here is not self
+        def not_a_method(not_self):
+            return not_self.a
+            #               ^ defined:
+
+
+def function(self):
+    self.a
+    #    ^ defined:

languages/tree-sitter-stack-graphs-python/test/self.py

@@ -0,0 +1,11 @@
+class Foo:
+    a = 1
+
+    def mathod_1(self):
+        return self.a
+        #           ^ defined: 2
+
+    # Self can be named anything
+    def method_2(actually_self):
+        return actually_self.a
+        #                    ^ defined: 2