Skip to content
This repository was archived by the owner on Nov 1, 2017. It is now read-only.

Commit 0bae328

Browse files
committed
Expose $.fn.taskList instead
1 parent 9edd54a commit 0bae328

File tree

4 files changed

+20
-11
lines changed

4 files changed

+20
-11
lines changed

app/assets/javascripts/task_lists.coffee

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,8 @@ enableTaskList = ($container) ->
179179
trigger 'tasklist:enabled'
180180

181181
# Enables a collection of TaskList containers.
182-
$.fn.enableTaskList = ->
183-
for container in this
182+
enableTaskLists = ($containers) ->
183+
for container in $containers
184184
enableTaskList $(container)
185185

186186
# Disable TaskList item changes.
@@ -192,10 +192,19 @@ disableTaskList = ($container) ->
192192
trigger 'tasklist:disabled'
193193

194194
# Disables a collection of TaskList containers.
195-
$.fn.disableTaskList = ->
196-
for container in this
195+
disableTaskLists = ($containers) ->
196+
for container in $containers
197197
disableTaskList $(container)
198198

199+
$.fn.taskList = (method) ->
200+
$container = $(this).closest('.js-task-list-container')
201+
202+
methods =
203+
enable: enableTaskLists
204+
disable: disableTaskLists
205+
206+
methods[method || 'enable']($container)
207+
199208
# When the page is updated, enable new TaskList containers.
200209
$.pageUpdate ->
201-
$('.js-task-list-container.js-task-list-enable').enableTaskList()
210+
$('.js-task-list-container.js-task-list-enable').taskList()

test/functional/test_task_lists_behavior.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
$(document).on('tasklist:disabled', logEvent)
1919
$(document).on('tasklist:change', '.js-task-list-field', function(event){
2020
logEvent(event)
21-
$(this).closest('.js-task-list-container').disableTaskList()
21+
$(this).closest('.js-task-list-container').taskList('disable')
2222
})
2323
$(document).on('tasklist:changed', '.js-task-list-field', function(event){
2424
logEvent(event)
@@ -28,7 +28,7 @@
2828
$(document).on('ajaxStart', logEvent)
2929
$(document).on('ajaxSuccess', '.js-task-list-container', function(event){
3030
logEvent(event)
31-
$(this).enableTaskList()
31+
$(this).taskList()
3232
})
3333
</script>
3434

test/unit/test_events.coffee

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ module "TaskList events",
2121
@container.append @field
2222

2323
$('#qunit-fixture').append(@container)
24-
@container.enableTaskList()
24+
@container.taskList()
2525

2626
teardown: ->
2727
$(document).off 'tasklist:enabled'
@@ -77,7 +77,7 @@ asyncTest "enables task list items when a .js-task-list-field is present", ->
7777
$(document).on 'tasklist:enabled', (event) ->
7878
ok true
7979

80-
@container.enableTaskList()
80+
@container.taskList()
8181
setTimeout ->
8282
start()
8383
, 20
@@ -90,7 +90,7 @@ asyncTest "doesn't enable task list items when a .js-task-list-field is absent",
9090

9191
@field.remove()
9292

93-
@container.enableTaskList()
93+
@container.taskList()
9494
setTimeout ->
9595
start()
9696
, 20

test/unit/test_updates.coffee

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ module "TaskList updates",
4747
@container.append @field
4848

4949
$('#qunit-fixture').append(@container)
50-
@container.enableTaskList()
50+
@container.taskList()
5151

5252
teardown: ->
5353
$(document).off 'tasklist:changed'

0 commit comments

Comments
 (0)