Merge pull request #19 from github/fire-args-deprecated

Replace deprecated calls to $.fn.fire with $.fn.trigger

Author: mtodd

app/assets/javascripts/task_lists.coffee

@@ -5,7 +5,6 @@
 #= provides tasklist:change
 #= provides tasklist:changed
 #
-#= require crema/events/fire
 #= require crema/events/pageupdate
 #
 # Enables Task List update behavior.
@@ -168,10 +167,13 @@ updateTaskList = ($item) ->
   index      = 1 + $container.find('.task-list-item-checkbox').index($item)
   checked    = $item.prop 'checked'
 
-  $field.fire 'tasklist:change', [index, checked], ->
+  event = $.Event 'tasklist:change'
+  $field.trigger event, [index, checked]
+
+  unless event.isDefaultPrevented()
     $field.val updateTaskListItem($field.val(), index, checked)
     $field.trigger 'change'
-    $field.fire 'tasklist:changed', [index, checked]
+    $field.trigger 'tasklist:changed', [index, checked]
 
 # When the task list item checkbox is updated, submit the change
 $(document).on 'change', '.task-list-item-checkbox', ->

lib/task_list/version.rb

@@ -1,3 +1,3 @@
 class TaskList
-  VERSION = [0, 2, 0].join('.')
+  VERSION = [0, 2, 1].join('.')
 end

task-lists.gemspec

@@ -24,4 +24,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "json"
   gem.add_development_dependency "rack"
   gem.add_development_dependency "sprockets"
+  gem.add_development_dependency "minitest", "~> 5.3.2"
 end

test/functional/helpers/remote.coffee

@@ -1,3 +1,3 @@
 #= require jquery
-#= require rails/remote
+#= require rails-behaviors/remote
 #= require task_lists

test/task_list/filter_test.rb

@@ -2,7 +2,7 @@
 require File.expand_path('../../test_helper', __FILE__)
 require 'task_list/filter'
 
-class TaskList::FilterTest < Test::Unit::TestCase
+class TaskList::FilterTest < Minitest::Test
   def setup
     @pipeline = HTML::Pipeline.new [
       HTML::Pipeline::MarkdownFilter,

test/task_list/summary_test.rb

@@ -2,7 +2,7 @@
 require File.expand_path('../../test_helper', __FILE__)
 require 'task_list/summary'
 
-class TaskList::SummaryTest < Test::Unit::TestCase
+class TaskList::SummaryTest < Minitest::Test
   def setup
     @complete   = make_item "[x]", "complete"
     @incomplete = make_item "[ ]", "incomplete"

test/task_list_test.rb

@@ -3,7 +3,7 @@
 require 'task_list'
 require 'task_list/filter'
 
-class TaskListTest < Test::Unit::TestCase
+class TaskListTest < Minitest::Test
   class Record < Struct.new(:body)
     def task_list_items
       []

test/test_helper.rb

@@ -1,3 +1,3 @@
 $:.unshift "lib"
-require 'test/unit'
+require 'minitest/autorun'
 require 'task_list'