Merge pull request #38 from github/ignore-links-on-update

Ignore links when updating task list items

Author: mtodd

app/assets/javascripts/task_list.coffee

@@ -125,7 +125,11 @@ itemPattern = ///
     #{escapePattern(complete)}|
     #{escapePattern(incomplete)}
   )
-  (?=\s)                  # followed by whitespace
+  (?!                     # is not a link
+    \s*                   # with optional whitespace
+    (?:\(.*?\)|\[.*?\])   # because of destination or reference
+  )
+  (?=\s)                  # is followed by whitespace
 ///
 
 # Used to filter out code fences from the source for comparison only.

test/unit/test_updates.coffee

@@ -440,3 +440,69 @@ asyncTest "update ignores items that look like Task List items but lack list pre
   , 20
 
   item2Checkbox.click()
+
+asyncTest "update ignores items that look like Task List items but are links", ->
+  expect 3
+
+  $('#qunit-fixture').empty()
+
+  container = $ '<div>', class: 'js-task-list-container'
+
+  list = $ '<ul>', class: 'task-list'
+
+  item1 = $ '<li>', class: 'task-list-item'
+  item1Checkbox = $ '<input>',
+    type: 'checkbox'
+    class: 'task-list-item-checkbox'
+    disabled: true
+    checked: false
+
+  item2 = $ '<li>', class: 'task-list-item'
+  item2Checkbox = $ '<input>',
+    type: 'checkbox'
+    class: 'task-list-item-checkbox'
+    disabled: true
+    checked: false
+
+  field = $ '<textarea>', class: 'js-task-list-field', text: """
+    - [ ] (link)
+    - [ ] [reference]
+    - [ ] () collapsed
+    - [ ] [] collapsed reference
+    - [ ] \\(escaped item)
+    - [ ] item
+  """
+
+  changes = """
+    - [ ] (link)
+    - [ ] [reference]
+    - [ ] () collapsed
+    - [ ] [] collapsed reference
+    - [ ] \\(escaped item)
+    - [x] item
+  """
+
+  item1.append item1Checkbox
+  list.append item1
+  item1.expectedIndex = 1
+
+  item2.append item2Checkbox
+  list.append item2
+  item2.expectedIndex = 2
+
+  container.append list
+  container.append field
+
+  $('#qunit-fixture').append(container)
+  container.taskList()
+
+  field.on 'tasklist:changed', (event, index, checked) =>
+    ok checked
+    equal index, item2.expectedIndex
+    equal field.val(), changes
+
+  setTimeout ->
+    start()
+  , 20
+
+  item2Checkbox.click()