Skip to content
This repository was archived by the owner on Nov 1, 2017. It is now read-only.

Commit d38962b

Browse files
committed
Compute index lazily
No need to precompute it. //cc @josh
1 parent 7d6a0fe commit d38962b

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

app/assets/javascripts/task_lists.coffee

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,12 +114,9 @@ updateTaskListItem = (source, itemIndex, checked) ->
114114
# Enables task list items to trigger updates.
115115
enableTaskList = ($container) ->
116116
if $container.find('.js-task-list-field').length > 0
117-
index = 0
118117
$container.
119118
find('.task-list-item').addClass('enabled').
120119
find('.task-list-item-checkbox').attr('disabled', null)
121-
for item, i in $container.find('.task-list-item-checkbox')
122-
$(item).data('taskListItemIndex', i+1)
123120
$container.trigger 'tasklist:enabled'
124121

125122
disableTaskList = ($container) ->
@@ -133,7 +130,7 @@ disableTaskList = ($container) ->
133130
updateTaskList = ($item) ->
134131
$container = $item.closest '.js-task-list-container'
135132
$field = $container.find '.js-task-list-field'
136-
index = $item.data('taskListItemIndex')
133+
index = 1 + $container.find('.task-list-item-checkbox').index($item)
137134
checked = $item.prop 'checked'
138135

139136
disableTaskList $container

0 commit comments

Comments
 (0)