Skip to content

Commit 1d56055

Browse files
author
Jordan McCullough
committed
Merge pull request #300 from github/slide-page-fixes
Bug fix for slide, slide-only modes with `?teacher=` feature
2 parents a97aa36 + cb589b3 commit 1d56055

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

_javascript/curriculum.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@ $(function(){
33

44
// Bind checkbox/label click for slide toggle
55
$("#slide-only-toggle").change(function(){
6-
var checkState = $("#slide-only-toggle").attr("checked");
7-
$(".materials > *").toggleClass("hidden");
8-
$(".slide").toggleClass("hidden");
6+
$(".materials > *").not(".slide").toggleClass("hidden");
97
});
108

119
// Parse username from querystring
@@ -21,7 +19,7 @@ $(function(){
2119
url: "https://api.github.com/users/"+username,
2220
success: function(data, textStatus, jqXHR){
2321
$("#teacher-name").html(data.name);
24-
22+
2523
$("<span/>",
2624
{
2725
text: data.login
@@ -86,7 +84,6 @@ $(function(){
8684
}).appendTo("#teacher-following");
8785

8886
$("#teacher").toggleClass("hidden");
89-
$("#teacher").toggleClass("slide");
9087

9188
updateSlideSize();
9289
}
@@ -130,7 +127,7 @@ $(function(){
130127
even = $("hr:even");
131128

132129
even.each(function(index){
133-
$(this).nextUntil("hr").wrapAll("<div class='slide'><div class='alignment'></div>");
130+
$(this).nextUntil("hr").wrapAll("<div class='slide'><div class='alignment'></div></div>");
134131
});
135132

136133
$(".slide").css("height", h + "px");

_layouts/curriculum.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,9 @@ <h4 class="modal-title" id="timerModalLabel">Help / Shortcuts</h4>
6666
</div>
6767

6868
<div class="col-content deck col-md-12 col-sm-12 col-xs-12 materials curriculum shift-left">
69-
<div id="teacher" class="hidden">
69+
<div id="teacher" class="slide hidden">
7070
<div class="alignment">
71-
<div id="teacher-avatar" class=""></div>
71+
<div id="teacher-avatar"></div>
7272
<div class="" id="teacher-info">
7373

7474
<h3 id="teacher-name"></h3>

0 commit comments

Comments
 (0)