Merge pull request #3 from hazukitenki/main

Fix Delay Attributes

Author: koddsson

src/index.ts

@@ -47,7 +47,7 @@ class TypingEffectElement extends HTMLElement {
     if (this.prefersReducedMotion) {
       return 0
     }
-    return Math.max(Math.min(0, Math.floor(Number(this.getAttribute('data-character-delay'))), 2_147_483_647)) || 40
+    return Math.max(0, Math.min(Math.floor(Number(this.getAttribute('data-character-delay'))), 2_147_483_647)) || 40
   }
 
   set characterDelay(value: number) {
@@ -61,7 +61,7 @@ class TypingEffectElement extends HTMLElement {
     if (this.prefersReducedMotion) {
       return 0
     }
-    return Math.max(Math.min(0, Math.floor(Number(this.getAttribute('data-line-delay'))), 2_147_483_647)) || 40
+    return Math.max(0, Math.min(Math.floor(Number(this.getAttribute('data-line-delay'))), 2_147_483_647)) || 40
   }
 
   set lineDelay(value: number) {

test/test.js

@@ -90,6 +90,19 @@ describe('typing-effect', function () {
       assert.equal(typingEffectElement.characterDelay, 40)
       assert.equal(typingEffectElement.lineDelay, 40)
     })
+
+    it('uses specified delay attributes instead of using defaults', function () {
+      const characterDelay = 20
+      const lineDelay = 20
+      document.body.innerHTML = `
+        <typing-effect data-character-delay="${characterDelay}" data-line-delay="${lineDelay}">
+        </typing-effect>
+      `
+      const typingEffectElement = document.querySelector('typing-effect')
+
+      assert.equal(typingEffectElement.characterDelay, characterDelay)
+      assert.equal(typingEffectElement.lineDelay, lineDelay)
+    })
   })
 
   describe('a11y considerations', function () {