Merge pull request #57 from github/rashiq-vitess-v1502

Author: rashiq

.gitattributes

@@ -4,4 +4,3 @@ web/vtadmin/src/proto/*.ts -diff
 go/vt/proto/** linguist-generated=true
 go/vt/proto/*/*.pb.go -diff
 go/vt/sqlparser/sql.go linguist-generated=true -diff
-go/vt/mysqlctl/rice-box.go linguist-generated=true -diff

.github/CODEOWNERS

@@ -1,51 +1,75 @@
-bootstrap.sh @deepthi
+* @deepthi
+bootstrap.sh @ajm188 @deepthi @frouioui @vmg
+/.github/ISSUE_TEMPLATE/ @deepthi @frouioui @mattlord
+/.github/workflows/ @deepthi @frouioui @mattlord
 /config/mycnf/ @deepthi @shlomi-noach @mattlord
-/docker/ @derekperkins @dkhenry @mattlord
-/examples/compose @shlomi-noach
-/examples/demo @sougou @mattlord
+/doc/ @deepthi @frouioui @GuptaManan100 @rsajwani
+/docker/ @deepthi @derekperkins @dkhenry @mattlord
+/examples/compose @shlomi-noach @GuptaManan100 @frouioui
+/examples/demo @mattlord @rohit-nayak-ps
 /examples/legacy_local @deepthi
-/examples/local @rohit-nayak-ps @frouioui @mattlord
-/examples/operator @GuptaManan100 @frouioui
-/examples/region_sharding @deepthi
+/examples/local @rohit-nayak-ps @frouioui @mattlord @GuptaManan100
+/examples/operator @GuptaManan100 @frouioui @mattlord
+/examples/region_sharding @deepthi @mattlord
 /java/ @harshit-gangal
 /go/cache @vmg
-/go/cmd @ajm188
-/go/cmd/vtadmin @ajm188 @doeg @notfelineit
-/go/cmd/vtctldclient @ajm188 @doeg @notfelineit
-/go/internal/flag @ajm188
+/go/cmd @ajm188 @deepthi
+/go/cmd/vtadmin @ajm188 @notfelineit
+/go/cmd/vtctldclient @ajm188 @notfelineit
+/go/internal/flag @ajm188 @rohit-nayak-ps
 /go/mysql @harshit-gangal @systay @mattlord
-/go/protoutil @ajm188
-/go/test/endtoend/onlineddl @shlomi-noach
-/go/test/endtoend/orchestrator @deepthi @shlomi-noach @GuptaManan100
+/go/pools @deepthi @harshit-gangal
+/go/protoutil @ajm188 @deepthi
+/go/sqltypes @harshit-gangal @shlomi-noach @vmg
+/go/test/endtoend/onlineddl @rohit-nayak-ps @shlomi-noach
 /go/test/endtoend/messaging @mattlord @rohit-nayak-ps @derekperkins
 /go/test/endtoend/vtgate @harshit-gangal @systay @frouioui
-/go/vt/discovery @deepthi
-/go/vt/mysqlctl @deepthi @mattlord
-/go/vt/orchestrator @deepthi @shlomi-noach @GuptaManan100
-/go/vt/proto/vtadmin @ajm188 @doeg @notfelineit
-/go/vt/schema @shlomi-noach
+/go/test/endtoend/vtorc @deepthi @shlomi-noach @GuptaManan100 @rsajwani
+/go/tools/ @frouioui @systay
+/go/vt/dbconnpool @harshit-gangal @mattlord
+/go/vt/discovery @deepthi @frouioui
+/go/vt/mysqlctl @deepthi @mattlord @rsajwani
+/go/vt/proto @deepthi @harshit-gangal @mattlord
+/go/vt/proto/vtadmin @ajm188 @notfelineit
+/go/vt/schema @mattlord @shlomi-noach
 /go/vt/servenv @deepthi @ajm188
 /go/vt/sqlparser @harshit-gangal @systay @GuptaManan100
-/go/vt/srvtopo @rafael
-/go/vt/topo @deepthi @rafael
-/go/vt/vtadmin @ajm188 @doeg @notfelineit @rohit-nayak-ps
-/go/vt/vtctl @deepthi
-/go/vt/vtctl/vtctl.go @ajm188 @doeg @notfelineit
-/go/vt/vtctl/grpcvtctldclient @ajm188 @doeg @notfelineit
-/go/vt/vtctl/grpcvtctldserver @ajm188 @doeg @notfelineit
-/go/vt/vtctl/vtctldclient @ajm188 @doeg @notfelineit
-/go/vt/vtctld @ajm188 @deepthi @doeg @notfelineit @rohit-nayak-ps
-/go/vt/vtexplain @systay
-/go/vt/vtgate @harshit-gangal @systay @frouioui
-/go/vt/vttablet/tabletmanager @deepthi @shlomi-noach
+/go/vt/srvtopo @deepthi @rafael @mattlord
+/go/vt/sysvars @harshit-gangal @systay
+/go/vt/topo @deepthi @rafael @mattlord @rsajwani
+/go/vt/topotools @deepthi @rafael @mattlord @rsajwani
+/go/vt/vitessdriver @harshit-gangal
+/go/vt/vtadmin @ajm188 @notfelineit @rohit-nayak-ps
+/go/vt/vtctl @ajm188 @deepthi @rohit-nayak-ps
+/go/vt/vtctl/vtctl.go @notfelineit @rohit-nayak-ps
+/go/vt/vtctl/grpcvtctldclient @ajm188 @notfelineit
+/go/vt/vtctl/grpcvtctldserver @ajm188 @notfelineit
+/go/vt/vtctl/reparentutil @ajm188 @GuptaManan100 @deepthi
+/go/vt/vtctl/vtctldclient @ajm188 @notfelineit
+/go/vt/vtctld @ajm188 @deepthi @notfelineit @rohit-nayak-ps
+/go/vt/vterrors @harshit-gangal @systay
+/go/vt/vtexplain @systay @harshit-gangal
+/go/vt/vtgate @harshit-gangal @systay @frouioui @GuptaManan100
+/go/vt/vtorc @deepthi @shlomi-noach @GuptaManan100 @rsajwani
+/go/vt/vttablet/*conn* @harshit-gangal @systay
+/go/vt/vttablet/endtoend @harshit-gangal @mattlord @rohit-nayak-ps @systay
+/go/vt/vttablet/grpc* @ajm188 @rohit-nayak-ps @rsajwani @shlomi-noach @harshit-gangal
+/go/vt/vttablet/onlineddl @mattlord @rohit-nayak-ps @shlomi-noach
+/go/vt/vttablet/queryservice @harshit-gangal @systay
+/go/vt/vttablet/tabletmanager @deepthi @GuptaManan100 @rohit-nayak-ps @rsajwani @shlomi-noach
 /go/vt/vttablet/tabletmanager/vreplication @rohit-nayak-ps @mattlord
 /go/vt/vttablet/tabletmanager/vstreamer @rohit-nayak-ps @mattlord
-/go/vt/vttablet/tabletserver @harshit-gangal @systay @shlomi-noach
+/go/vt/vttablet/tabletserver* @harshit-gangal @systay @shlomi-noach @rohit-nayak-ps
 /go/vt/vttablet/tabletserver/messager @mattlord @rohit-nayak-ps @derekperkins
-/go/vt/wrangler @deepthi @rohit-nayak-ps @mattlord
-/go/vt/workflow @rohit-nayak-ps @mattlord
-/proto/vtadmin.proto @ajm188 @doeg @notfelineit
-/proto/vtctldata.proto @ajm188 @doeg @notfelineit
-/proto/vtctlservice.proto @ajm188 @doeg @notfelineit
-/web/vtadmin @ajm188 @doeg @notfelineit
-/web/vtctld2 @doeg @notfelineit @rohit-nayak-ps
+/go/vt/vttablet/*tmclient* @ajm188 @GuptaManan100 @rohit-nayak-ps @rsajwani @shlomi-noach
+/go/vt/vttablet/vexec @mattlord @rohit-nayak-ps @shlomi-noach
+/go/vt/wrangler @deepthi @mattlord @rohit-nayak-ps
+/go/vt/workflow @mattlord @rohit-nayak-ps
+/proto/ @deepthi @harshit-gangal
+/proto/vtadmin.proto @ajm188 @notfelineit
+/proto/vtctldata.proto @ajm188 @notfelineit
+/proto/vtctlservice.proto @ajm188 @notfelineit
+/test/ @GuptaManan100 @frouioui @rohit-nayak-ps
+/tools/ @frouioui @rohit-nayak-ps
+/web/vtadmin @ajm188 @notfelineit
+/web/vtctld2 @notfelineit @rohit-nayak-ps

.github/docker/cluster_test_12/Dockerfile

@@ -18,7 +18,7 @@
 
 ## Checklist
 
--   [ ] "Backport me!" label has been added if this change should be backported
+-   [ ] "Backport to:" labels have been added if this change should be back-ported
 -   [ ] Tests were added or are not required
 -   [ ] Documentation was added or is not required
 

.github/docker/cluster_test_18/Dockerfile

@@ -14,7 +14,7 @@ jobs:
           skip='true'
         fi
         echo Skip ${skip}
-        echo "::set-output name=skip-workflow::${skip}"
+        echo "skip-workflow=${skip}" >> $GITHUB_OUTPUT
 
     - name: Check out code
       if: steps.skip-workflow.outputs.skip-workflow == 'false'
@@ -31,15 +31,17 @@ jobs:
             - 'bootstrap.sh'
             - 'tools/**'
             - 'build.env'
-            - 'go.[sumod]'
+            - 'go.sum'
+            - 'go.mod'
             - 'Makefile'
             - 'go/vt/vtadmin/**'
+            - '.github/workflows/check_make_vtadmin_authz_testgen.yml'
 
     - name: Set up Go
       uses: actions/setup-go@v2
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.vtadmin_changes == 'true'
       with:
-        go-version: 1.18.4
+        go-version: 1.18.9
 
     - name: Tune the OS
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.vtadmin_changes == 'true'

.github/pull_request_template.md

@@ -14,7 +14,7 @@ jobs:
           skip='true'
         fi
         echo Skip ${skip}
-        echo "::set-output name=skip-workflow::${skip}"
+        echo "skip-workflow=${skip}" >> $GITHUB_OUTPUT
 
     - name: Check out code
       if: steps.skip-workflow.outputs.skip-workflow == 'false'
@@ -31,17 +31,19 @@ jobs:
             - 'bootstrap.sh'
             - 'tools/**'
             - 'build.env'
-            - 'go.[sumod]'
+            - 'go.sum'
+            - 'go.mod'
             - 'Makefile'
             - 'go/vt/proto/**'
             - 'proto/*.proto'
             - 'web/vtadmin/src/proto/**'
+            - '.github/workflows/check_make_vtadmin_web_proto.yml'
 
     - name: Set up Go
       uses: actions/setup-go@v2
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.proto_changes == 'true'
       with:
-        go-version: 1.18.4
+        go-version: 1.18.9
 
     - name: Setup Node
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.proto_changes == 'true'

.github/workflows/check_make_vtadmin_authz_testgen.yml

@@ -0,0 +1,32 @@
+name: close_stale_pull_requests
+on:
+  schedule:
+    - cron: '0 1 * * *'
+
+  workflow_dispatch: {}
+
+permissions:
+  pull-requests: write
+
+jobs:
+  close_stale_pull_requests:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/stale@v5
+        with:
+          days-before-stale: 30
+          # Do not handle issues at all. We only want to handle PRs.
+          days-before-issue-stale: -1
+
+          stale-pr-message: |
+            This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
+
+            - Push additional commits to the associated branch.
+            - Remove the stale label.
+            - Add a comment indicating why it is not stale.
+
+            If no action is taken within 7 days, this PR will be closed.
+          close-pr-message: "This PR was closed because it has been stale for 7 days with no activity."
+
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+