add tests

Signed-off-by: Mohamed Hamza <[email protected]>

Author: mhamza15

go/stats/export.go

@@ -100,10 +100,11 @@ func (vg *varGroup) publish(name string, v expvar.Var) {
 	vg.Lock()
 	defer vg.Unlock()
 
-	// Check if the variable is already registered
+	// Ignore if the variable is already registered
 	if v := expvar.Get(name); v != nil {
 		return
 	}
+
 	expvar.Publish(name, v)
 	if vg.newVarHook != nil {
 		vg.newVarHook(name, v)

go/vt/vttablet/tabletserver/connpool/pool_test.go

@@ -50,6 +50,48 @@ func TestConnPoolGet(t *testing.T) {
 	dbConn.Recycle()
 }
 
+func TestReopenPool(t *testing.T) {
+	db := fakesqldb.New(t)
+	defer db.Close()
+
+	cfg := tabletenv.ConnPoolConfig{
+		Size:        1,
+		Timeout:     time.Second,
+		IdleTimeout: 10 * time.Second,
+	}
+	env := tabletenv.NewEnv(vtenv.NewTestEnv(), nil, "PoolTest")
+	params := dbconfigs.New(db.ConnParams())
+
+	connPool := NewPool(env, "TestPool", cfg)
+	connPool.Open(params, params, params)
+	connPool.Close()
+
+	connPool = NewPool(env, "TestPool", cfg)
+	connPool.Open(params, params, params)
+	connPool.Close()
+}
+
+func TestReopenPoolUnnamedEnv(t *testing.T) {
+	db := fakesqldb.New(t)
+	defer db.Close()
+
+	cfg := tabletenv.ConnPoolConfig{
+		Size:        1,
+		Timeout:     time.Second,
+		IdleTimeout: 10 * time.Second,
+	}
+	env := tabletenv.NewEnv(vtenv.NewTestEnv(), nil, "")
+	params := dbconfigs.New(db.ConnParams())
+
+	connPool := NewPool(env, "TestPool", cfg)
+	connPool.Open(params, params, params)
+	connPool.Close()
+
+	connPool = NewPool(env, "TestPool", cfg)
+	connPool.Open(params, params, params)
+	connPool.Close()
+}
+
 func TestConnPoolTimeout(t *testing.T) {
 	db := fakesqldb.New(t)
 	defer db.Close()