[release-20.0] Atomic Copy: Handle error that was ignored while streaming tables and log it (vitessio#18313) (vitessio#18314)

Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Manan Gupta <[email protected]>

Author: vitess-bot[bot]

go/vt/vttablet/tabletserver/vstreamer/tablestreamer.go

@@ -116,6 +116,8 @@ func (ts *tableStreamer) Stream() error {
 	if _, err := conn.ExecuteFetch(fmt.Sprintf("set @@session.net_write_timeout = %v", vttablet.VReplicationNetWriteTimeout), 1, false); err != nil {
 		return err
 	}
+	log.Infof("TableStreamer Stream() started with net read_timeout: %v, net write_timeout: %v",
+		vttablet.VReplicationNetReadTimeout, vttablet.VReplicationNetWriteTimeout)
 
 	rs, err := conn.ExecuteFetch("show full tables", -1, true)
 	if err != nil {
@@ -137,6 +139,7 @@ func (ts *tableStreamer) Stream() error {
 	for _, tableName := range ts.tables {
 		log.Infof("Streaming table %s", tableName)
 		if err := ts.streamTable(ts.ctx, tableName); err != nil {
+			log.Errorf("Streaming table %s failed: %v", tableName, err)
 			return err
 		}
 		log.Infof("Finished streaming table %s", tableName)
@@ -194,7 +197,8 @@ func (ts *tableStreamer) streamTable(ctx context.Context, tableName string) erro
 	}
 	defer cancel()
 
-	if rs.Stream() != nil {
+	err = rs.Stream()
+	if err != nil {
 		return err
 	}
 	rs.vse.tableStreamerNumTables.Add(int64(1))