Merge pull request #3818 from asgerf/asgerf/simplify-conditional-hooks

Compare-perf: Check for nullness of 'data' in a separate component

Author: asgerf

extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx

@@ -359,14 +359,23 @@ export function ComparePerformance(_: Record<string, never>) {
     [setData],
   );
 
-  const datasets = useMemo(
-    () =>
-      data == null
-        ? undefined
-        : {
-            from: new ComparisonDataset(data.from),
-            to: new ComparisonDataset(data.to),
-          },
+  if (!data) {
+    return <div>Loading performance comparison...</div>;
+  }
+
+  return <ComparePerformanceWithData data={data} />;
+}
+
+function ComparePerformanceWithData(props: {
+  data: SetPerformanceComparisonQueries;
+}) {
+  const { data } = props;
+
+  const { from, to } = useMemo(
+    () => ({
+      from: new ComparisonDataset(data.from),
+      to: new ComparisonDataset(data.to),
+    }),
     [data],
   );
 
@@ -380,12 +389,6 @@ export function ComparePerformance(_: Record<string, never>) {
 
   const [metric, setMetric] = useState<Metric>(metrics.tuples);
 
-  if (!datasets) {
-    return <div>Loading performance comparison...</div>;
-  }
-
-  const { from, to } = datasets;
-
   const nameSet = new Set(from.data.names);
   for (const name of to.data.names) {
     nameSet.add(name);