Merge pull request #3839 from github/koesie10/switch-to-execa

Remove unmaintained child-process-promise

Author: koesie10

extensions/ql-vscode/gulpfile.ts/package.ts

@@ -1,6 +1,6 @@
 import { resolve } from "path";
 import { deployPackage } from "./deploy";
-import { spawn } from "child-process-promise";
+import { spawn } from "cross-spawn";
 
 export async function packageExtension(): Promise<void> {
   const deployedPackage = await deployPackage();
@@ -16,16 +16,22 @@ export async function packageExtension(): Promise<void> {
       `${deployedPackage.name}-${deployedPackage.version}.vsix`,
     ),
     "--no-dependencies",
+    "--skip-license",
   ];
   const proc = spawn(resolve(__dirname, "../node_modules/.bin/vsce"), args, {
     cwd: deployedPackage.distPath,
-  });
-  proc.childProcess.stdout!.on("data", (data) => {
-    console.log(data.toString());
-  });
-  proc.childProcess.stderr!.on("data", (data) => {
-    console.error(data.toString());
+    stdio: ["ignore", "inherit", "inherit"],
   });
 
-  await proc;
+  await new Promise((resolve, reject) => {
+    proc.on("error", reject);
+
+    proc.on("close", (code) => {
+      if (code === 0) {
+        resolve(undefined);
+      } else {
+        reject(new Error(`Failed to package extension with code ${code}`));
+      }
+    });
+  });
 }