Skip to content

Commit 724370f

Browse files
authored
Fix ModelAlerts view stories (#3490)
1 parent 4deae2f commit 724370f

File tree

2 files changed

+27
-8
lines changed

2 files changed

+27
-8
lines changed

extensions/ql-vscode/src/stories/model-alerts/ModelAlerts.stories.tsx

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import type { Meta, StoryFn } from "@storybook/react";
22

33
import { ModelAlerts as ModelAlertsComponent } from "../../view/model-alerts/ModelAlerts";
4+
import { createMockVariantAnalysis } from "../../../test/factories/variant-analysis/shared/variant-analysis";
45

56
export default {
67
title: "Model Alerts/Model Alerts",
@@ -14,4 +15,16 @@ const Template: StoryFn<typeof ModelAlertsComponent> = (args) => (
1415
export const ModelAlerts = Template.bind({});
1516
ModelAlerts.args = {
1617
initialViewState: { title: "codeql/sql2o-models" },
18+
variantAnalysis: createMockVariantAnalysis({
19+
modelPacks: [
20+
{
21+
name: "Model pack 1",
22+
path: "/path/to/model-pack-1",
23+
},
24+
{
25+
name: "Model pack 2",
26+
path: "/path/to/model-pack-2",
27+
},
28+
],
29+
}),
1730
};

extensions/ql-vscode/src/view/model-alerts/ModelAlerts.tsx

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,17 @@ import { vscode } from "../vscode-api";
1111

1212
type Props = {
1313
initialViewState?: ModelAlertsViewState;
14+
variantAnalysis?: VariantAnalysis;
15+
repoStates?: VariantAnalysisScannedRepositoryState[];
16+
repoResults?: VariantAnalysisScannedRepositoryResult[];
1417
};
1518

16-
export function ModelAlerts({ initialViewState }: Props): React.JSX.Element {
19+
export function ModelAlerts({
20+
initialViewState,
21+
variantAnalysis: initialVariantAnalysis,
22+
repoStates: initialRepoStates = [],
23+
repoResults: initialRepoResults = [],
24+
}: Props): React.JSX.Element {
1725
const onOpenModelPackClick = useCallback((path: string) => {
1826
vscode.postMessage({
1927
t: "openModelPack",
@@ -33,13 +41,11 @@ export function ModelAlerts({ initialViewState }: Props): React.JSX.Element {
3341

3442
const [variantAnalysis, setVariantAnalysis] = useState<
3543
VariantAnalysis | undefined
36-
>(undefined);
37-
const [repoStates, setRepoStates] = useState<
38-
VariantAnalysisScannedRepositoryState[]
39-
>([]);
40-
const [repoResults, setRepoResults] = useState<
41-
VariantAnalysisScannedRepositoryResult[]
42-
>([]);
44+
>(initialVariantAnalysis);
45+
const [repoStates, setRepoStates] =
46+
useState<VariantAnalysisScannedRepositoryState[]>(initialRepoStates);
47+
const [repoResults, setRepoResults] =
48+
useState<VariantAnalysisScannedRepositoryResult[]>(initialRepoResults);
4349

4450
useEffect(() => {
4551
const listener = (evt: MessageEvent) => {

0 commit comments

Comments
 (0)