Skip to content

Commit 8aec438

Browse files
committed
Bump minimum VS Code version for warnings
1 parent 282bd22 commit 8aec438

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

extensions/ql-vscode/src/extension.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -300,12 +300,12 @@ const shouldUpdateOnNextActivationKey = "shouldUpdateOnNextActivation";
300300

301301
const codeQlVersionRange = DEFAULT_DISTRIBUTION_VERSION_RANGE;
302302

303-
// This is the minimum version of vscode that we _want_ to support. We want to update to Node 18, but that
304-
// requires 1.82 or later. If we change the minimum version in the package.json, then anyone on an older version of vscode will
303+
// This is the minimum version of vscode that we _want_ to support. We want to update to Node 20, but that
304+
// requires 1.90 or later. If we change the minimum version in the package.json, then anyone on an older version of vscode will
305305
// silently be unable to upgrade. So, the solution is to first bump the minimum version here and release. Then
306306
// bump the version in the package.json and release again. This way, anyone on an older version of vscode will get a warning
307307
// before silently being refused to upgrade.
308-
const MIN_VERSION = "1.82.0";
308+
const MIN_VERSION = "1.90.0";
309309

310310
function sendConfigTelemetryData() {
311311
const config: Record<string, string> = {};

0 commit comments

Comments
 (0)