Add 'View Autofixes' button to variant analysis view

Author: Jami Cogswell

extensions/ql-vscode/src/common/interface-types.ts

@@ -527,6 +527,11 @@ interface OpenQueryTextMessage {
   t: "openQueryText";
 }
 
+interface ViewAutofixesMessage {
+  t: "viewAutofixes";
+  filterSort?: RepositoriesFilterSortStateWithIds;
+}
+
 interface CopyRepositoryListMessage {
   t: "copyRepositoryList";
   filterSort?: RepositoriesFilterSortStateWithIds;
@@ -561,6 +566,7 @@ export type FromVariantAnalysisMessage =
   | RequestRepositoryResultsMessage
   | OpenQueryFileMessage
   | OpenQueryTextMessage
+  | ViewAutofixesMessage
   | CopyRepositoryListMessage
   | ExportResultsMessage
   | OpenLogsMessage

extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts

@@ -967,6 +967,10 @@ export class VariantAnalysisManager
     );
   }
 
+  public async viewAutofixes() {
+    // TODO
+  }
+
   public async copyRepoListToClipboard(
     variantAnalysisId: number,
     filterSort: RepositoriesFilterSortStateWithIds = defaultFilterSortState,

extensions/ql-vscode/src/variant-analysis/variant-analysis-view-manager.ts

@@ -34,4 +34,8 @@ export interface VariantAnalysisViewManager<
     variantAnalysisId: number,
     filterSort?: RepositoriesFilterSortStateWithIds,
   ): Promise<void>;
+  viewAutofixes(
+    variantAnalysisId: number,
+    filterSort?: RepositoriesFilterSortStateWithIds,
+  ): Promise<void>;
 }

extensions/ql-vscode/src/variant-analysis/variant-analysis-view.ts

@@ -135,6 +135,12 @@ export class VariantAnalysisView
       case "openQueryText":
         await this.manager.openQueryText(this.variantAnalysisId);
         break;
+      case "viewAutofixes":
+        await this.manager.viewAutofixes(
+          this.variantAnalysisId,
+          msg.filterSort,
+        );
+        break;
       case "copyRepositoryList":
         await this.manager.copyRepoListToClipboard(
           this.variantAnalysisId,

extensions/ql-vscode/src/view/variant-analysis/VariantAnalysis.tsx

@@ -105,6 +105,17 @@ export function VariantAnalysis({
     }
   }, []);
 
+  const viewAutofixes = useCallback(() => {
+    vscode.postMessage({
+      t: "viewAutofixes",
+      filterSort: {
+        ...filterSortState,
+        repositoryIds: selectedRepositoryIds,
+      },
+    });
+    sendTelemetry("variant-analysis-view-autofixes");
+  }, [filterSortState, selectedRepositoryIds]);
+
   const copyRepositoryList = useCallback(() => {
     vscode.postMessage({
       t: "copyRepositoryList",
@@ -148,6 +159,7 @@ export function VariantAnalysis({
         onOpenQueryFileClick={openQueryFile}
         onViewQueryTextClick={openQueryText}
         onStopQueryClick={stopQuery}
+        onViewAutofixesClick={viewAutofixes}
         onCopyRepositoryListClick={copyRepositoryList}
         onExportResultsClick={exportResults}
         onViewLogsClick={onViewLogsClick}

extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisActions.tsx

@@ -9,8 +9,10 @@ export type VariantAnalysisActionsProps = {
   stopQueryDisabled?: boolean;
 
   showResultActions?: boolean;
+  onViewAutofixesClick: () => void;
   onCopyRepositoryListClick: () => void;
   onExportResultsClick: () => void;
+  viewAutofixesDisabled?: boolean;
   copyRepositoryListDisabled?: boolean;
   exportResultsDisabled?: boolean;
 
@@ -55,8 +57,10 @@ export const VariantAnalysisActions = ({
   onStopQueryClick,
   stopQueryDisabled,
   showResultActions,
+  onViewAutofixesClick,
   onCopyRepositoryListClick,
   onExportResultsClick,
+  viewAutofixesDisabled,
   copyRepositoryListDisabled,
   exportResultsDisabled,
   hasSelectedRepositories,
@@ -66,6 +70,19 @@ export const VariantAnalysisActions = ({
     <Container>
       {showResultActions && (
         <>
+          <Button
+            secondary
+            onClick={onViewAutofixesClick}
+            disabled={viewAutofixesDisabled}
+          >
+            {chooseText({
+              hasSelectedRepositories,
+              hasFilteredRepositories,
+              normalText: "View Autofixes",
+              selectedText: "View Autofixes for selected results",
+              filteredText: "View Autofixes for filtered results",
+            })}
+          </Button>
           <Button
             secondary
             onClick={onCopyRepositoryListClick}

extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisHeader.tsx

@@ -34,6 +34,7 @@ type VariantAnalysisHeaderProps = {
 
   onStopQueryClick: () => void;
 
+  onViewAutofixesClick: () => void;
   onCopyRepositoryListClick: () => void;
   onExportResultsClick: () => void;
 
@@ -82,6 +83,7 @@ export const VariantAnalysisHeader = ({
   onOpenQueryFileClick,
   onViewQueryTextClick,
   onStopQueryClick,
+  onViewAutofixesClick,
   onCopyRepositoryListClick,
   onExportResultsClick,
   onViewLogsClick,
@@ -150,11 +152,13 @@ export const VariantAnalysisHeader = ({
           variantAnalysisStatus={variantAnalysis.status}
           showResultActions={(resultCount ?? 0) > 0}
           onStopQueryClick={onStopQueryClick}
+          onViewAutofixesClick={onViewAutofixesClick}
           onCopyRepositoryListClick={onCopyRepositoryListClick}
           onExportResultsClick={onExportResultsClick}
           stopQueryDisabled={!variantAnalysis.actionsWorkflowRunId}
           exportResultsDisabled={!hasDownloadedRepos}
           copyRepositoryListDisabled={!hasReposWithResults}
+          viewAutofixesDisabled={!hasReposWithResults}
           hasFilteredRepositories={
             variantAnalysis.scannedRepos?.length !==
             filteredRepositories?.length

extensions/ql-vscode/src/view/variant-analysis/__tests__/VariantAnalysisActions.spec.tsx

@@ -6,11 +6,13 @@ import { VariantAnalysisActions } from "../VariantAnalysisActions";
 
 describe(VariantAnalysisActions.name, () => {
   const onStopQueryClick = jest.fn();
+  const onViewAutofixesClick = jest.fn();
   const onCopyRepositoryListClick = jest.fn();
   const onExportResultsClick = jest.fn();
 
   afterEach(() => {
     onStopQueryClick.mockReset();
+    onViewAutofixesClick.mockReset();
     onCopyRepositoryListClick.mockReset();
     onExportResultsClick.mockReset();
   });
@@ -22,6 +24,7 @@ describe(VariantAnalysisActions.name, () => {
     reactRender(
       <VariantAnalysisActions
         onStopQueryClick={onStopQueryClick}
+        onViewAutofixesClick={onViewAutofixesClick}
         onCopyRepositoryListClick={onCopyRepositoryListClick}
         onExportResultsClick={onExportResultsClick}
         {...props}