Merge pull request #2702 from github/robertbrignull/ResultTables

Convert ResultTables to a function component

Author: robertbrignull

extensions/ql-vscode/src/view/results/ProblemsViewCheckbox.tsx

@@ -0,0 +1,36 @@
+import * as React from "react";
+import { ALERTS_TABLE_NAME } from "../../common/interface-types";
+import {
+  alertExtrasClassName,
+  toggleDiagnosticsClassName,
+} from "./result-table-utils";
+
+interface Props {
+  selectedTable: string;
+  problemsViewSelected: boolean;
+  handleCheckboxChanged: (event: React.ChangeEvent<HTMLInputElement>) => void;
+}
+
+export function ProblemsViewCheckbox(props: Props): JSX.Element | null {
+  const { selectedTable, problemsViewSelected, handleCheckboxChanged } = props;
+
+  if (selectedTable !== ALERTS_TABLE_NAME) {
+    return null;
+  }
+  return (
+    <div className={alertExtrasClassName}>
+      <div className={toggleDiagnosticsClassName}>
+        <input
+          type="checkbox"
+          id="toggle-diagnostics"
+          name="toggle-diagnostics"
+          onChange={handleCheckboxChanged}
+          checked={problemsViewSelected}
+        />
+        <label htmlFor="toggle-diagnostics">
+          Show results in Problems view
+        </label>
+      </div>
+    </div>
+  );
+}

extensions/ql-vscode/src/view/results/ResultCount.tsx

@@ -0,0 +1,29 @@
+import * as React from "react";
+import { ResultSet } from "../../common/interface-types";
+import { tableHeaderItemClassName } from "./result-table-utils";
+
+interface Props {
+  resultSet?: ResultSet;
+}
+
+function getResultCount(resultSet: ResultSet): number {
+  switch (resultSet.t) {
+    case "RawResultSet":
+      return resultSet.schema.rows;
+    case "InterpretedResultSet":
+      return resultSet.interpretation.numTotalResults;
+  }
+}
+
+export function ResultCount(props: Props): JSX.Element | null {
+  if (!props.resultSet) {
+    return null;
+  }
+
+  const resultCount = getResultCount(props.resultSet);
+  return (
+    <span className={tableHeaderItemClassName}>
+      {resultCount} {resultCount === 1 ? "result" : "results"}
+    </span>
+  );
+}