Deprecate codeQL.runningQueries.saveCache setting

Author: nickrolfe

extensions/ql-vscode/package.json

@@ -195,6 +195,7 @@
             "type": "boolean",
             "default": false,
             "scope": "window",
+            "deprecationMessage": "This setting no longer has any effect.",
             "description": "Aggressively save intermediate results to the disk cache. This may speed up subsequent queries if they are similar. Be aware that using this option will greatly increase disk usage and initial evaluation time."
           },
           "codeQL.runningQueries.cacheSize": {

extensions/ql-vscode/src/config.ts

@@ -226,7 +226,6 @@ const NUMBER_OF_THREADS_SETTING = new Setting(
   "numberOfThreads",
   RUNNING_QUERIES_SETTING,
 );
-const SAVE_CACHE_SETTING = new Setting("saveCache", RUNNING_QUERIES_SETTING);
 const CACHE_SIZE_SETTING = new Setting("cacheSize", RUNNING_QUERIES_SETTING);
 const TIMEOUT_SETTING = new Setting("timeout", RUNNING_QUERIES_SETTING);
 const MEMORY_SETTING = new Setting("memory", RUNNING_QUERIES_SETTING);
@@ -257,7 +256,6 @@ const CUSTOM_LOG_DIRECTORY_SETTING = new Setting(
 /** When these settings change, the running query server should be restarted. */
 const QUERY_SERVER_RESTARTING_SETTINGS = [
   NUMBER_OF_THREADS_SETTING,
-  SAVE_CACHE_SETTING,
   CACHE_SIZE_SETTING,
   MEMORY_SETTING,
   DEBUG_SETTING,
@@ -268,7 +266,6 @@ export interface QueryServerConfig {
   codeQlPath: string;
   debug: boolean;
   numThreads: number;
-  saveCache: boolean;
   cacheSize: number;
   queryMemoryMb?: number;
   timeoutSecs: number;
@@ -432,10 +429,6 @@ export class QueryServerConfigListener
     return NUMBER_OF_THREADS_SETTING.getValue<number>();
   }
 
-  public get saveCache(): boolean {
-    return SAVE_CACHE_SETTING.getValue<boolean>();
-  }
-
   public get cacheSize(): number {
     return CACHE_SIZE_SETTING.getValue<number | null>() || 0;
   }

extensions/ql-vscode/src/query-server/query-server-client.ts

@@ -190,10 +190,6 @@ export class QueryServerClient extends DisposableObject {
       ramArgs,
     );
 
-    if (this.config.saveCache) {
-      args.push("--save-cache");
-    }
-
     if (this.config.cacheSize > 0) {
       args.push("--max-disk-cache");
       args.push(this.config.cacheSize.toString());

extensions/ql-vscode/test/vscode-tests/minimal-workspace/config.test.ts

@@ -65,11 +65,6 @@ describe("config listeners", () => {
           property: "numThreads",
           values: [0, 1],
         },
-        {
-          name: "codeQL.runningQueries.saveCache",
-          property: "saveCache",
-          values: [false, true],
-        },
         {
           name: "codeQL.runningQueries.cacheSize",
           property: "cacheSize",