Use standard configuration variable format for history item labels #3799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbrignull
approved these changes
Nov 11, 2024
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
Code-wise LGTM. I can appreciate that the new part is basically a single call to substituteConfigVariables and the rest is the old legacy implementation.
It's a shame we do have to keep the legacy implementation, but of course we do have to continue supporting the old format (for potentially quite a long time if not forever).
I haven't tried running it, but I assume you have tested it and the automated tests look good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
codeQL.queryHistory.formatto use a format that is also used by VS Code, rather than using our own format. We will support the "legacy" format to ensure users that have configured this setting do not need to make any changes.