Use bqrs diff for all cases in the compare view when --result-sets is supported
#4211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes "Compare Results" use the new
--result-setsoption that was added to the CodeQL CLI. When this option is supported we can usebqrs diffin all cases, and only need to fall back to the in-extension diff for old CLI versions (where "old" at the time of writing is all released CLI versions 😉).I also made a small refactor to how we check for supported features. The new
supportsFeaturemethod automatically makes it possible to check for all the features in theCliFeaturestype, without requiring us to manually add a method for all features toCliVersionConstraint. This made theCliVersionConstraintclass superflous.Closes #1364.