Merge pull request #228 from atsju/JST/clazyArgs

pass by reference or by value when necessary

Author: atsju

IgramArea.h

@@ -85,7 +85,7 @@ class outlinePair{
 public:
     QImage m_image;
     CircleOutline m_outline;
-    outlinePair(QImage img, CircleOutline outline): m_image(img), m_outline(outline){}
+    outlinePair(const QImage &img, const CircleOutline &outline): m_image(img), m_outline(outline){}
 };
 
 class undoStack {
@@ -94,7 +94,7 @@ class undoStack {
 
 public:
     undoStack(){};
-    void push(QImage img, CircleOutline outline);
+    void push(const QImage &img, const CircleOutline &outline);
     outlinePair  current(){return m_stack.back();};
     outlinePair undo();
     outlinePair redo();
@@ -142,8 +142,8 @@ class IgramArea : public QWidget
     CircleOutline m_center;
     void hideOutline(bool checked);
     bool m_hideOutlines;
-    void loadOutlineFileOldV6(QString filename);
-    void loadOutlineFile(QString filename);
+    void loadOutlineFileOldV6(const QString &filename);
+    void loadOutlineFile(const QString &filename);
     void undo();
     void redo();
     void writeOutlinesOldV6(QString fileName);
@@ -152,23 +152,23 @@ class IgramArea : public QWidget
     void shiftoutline(QPointF p);
     void setZoomMode(zoomMode mode);
     void showAliasDialog();
-    cv::Mat igramToGray(cv::Mat roi);
+    cv::Mat igramToGray(const cv::Mat &roi);
     cv::Mat qImageToMat(QImage &roi);
 private slots:
     void aperatureChanged();
 public slots:
     void gammaChanged(bool, double);
     void generateSimIgram();
     void clearImage();
-    void dftReady(QImage img);
+    void dftReady(const QImage &img);
     void outlineTimerTimeout();
     void shiftUp();
     void shiftDown();
     void shiftRight();
     void shiftLeft();
     void zoomIn();
     void zoomOut();
-    void igramOutlineParmsChanged(outlineParms parms);
+    void igramOutlineParmsChanged(const outlineParms &parms);
     void increase( int i = 1);
     void decrease();
     void zoomFull();
@@ -218,8 +218,8 @@ public slots:
 
     double leftMargin;
     double searchOutlineScale;
-    cv::Point2d findBestOutsideOutline(cv::Mat gray, int start, int end, int step, int *radius, int pass);
-    cv::Point2d findBestCenterOutline(cv::Mat gray, int start, int end, int step, int *radius, bool useExisting);
+    cv::Point2d findBestOutsideOutline(const cv::Mat &gray, int start, int end, int step, int *radius, int pass);
+    cv::Point2d findBestCenterOutline(const cv::Mat &gray, int start, int end, int step, int *radius, bool useExisting);
     QString m_outlineMsg;
     double m_edgeMaskWidth;
     void saveRegions();

arbitrarywavwidget.cpp

@@ -54,7 +54,7 @@ ArbitraryWavWidget::~ArbitraryWavWidget(){
     pts.empty();
 }
 
-bool comparePoints(const QPointF &a, const QPointF &b) {
+bool comparePoints(QPointF a, QPointF b) {
     return a.x() < b.x();
 }
 

astigpolargraph.h

@@ -25,7 +25,7 @@ class astigSample{
     QString m_name;
     double m_xastig;
     double m_yastig;
-    astigSample(QString name, double xastig, double yastig): m_name(name), m_xastig(xastig), m_yastig(yastig){};
+    astigSample(const QString &name, double xastig, double yastig): m_name(name), m_xastig(xastig), m_yastig(yastig){};
 };
 
 class astigPolargraph : public QDialog

astigscatterplot.cpp

@@ -46,12 +46,12 @@ astigScatterPlot::astigScatterPlot(QWidget *parent):QwtPlot( parent ),m_max(.3)
     replot();
 }
 
-void astigScatterPlot::selectedwave(QString m){
+void astigScatterPlot::selectedwave(const QString &m){
     emit waveSeleted(m);
 }
 
 
-void astigScatterPlot::addValue(QString name, QPointF p){
+void astigScatterPlot::addValue(const QString &name, QPointF p){
     QwtPlotMarker *m = new QwtPlotMarker(name);
     if (fabs(p.x()) > m_max)
         m_max = fabs(p.x());

astigscatterplot.h

@@ -17,11 +17,11 @@ class astigScatterPlot : public QwtPlot
     double m_max;
 public:
     astigScatterPlot(QWidget *parent = 0);
-    void addValue(QString name, QPointF p);
+    void addValue(const QString &name, QPointF p);
 signals:
     void waveSeleted(QString m);
 public slots:
-    void selectedwave(QString);
+    void selectedwave(const QString&);
 };
 
 #endif // ASTIGSCATTERPLOT_H

astigstatsdlg.cpp

@@ -110,7 +110,7 @@ class CustomPlotPicker : public QwtPlotPicker {
         : QwtPlotPicker(xAxis, yAxis, QwtPicker::NoRubberBand, QwtPicker::AlwaysOn, canvas) {
     }
 
-    void addTooltipToPoint(const QPointF &point, const QString &tooltip){
+    void addTooltipToPoint(QPointF point, const QString &tooltip){
         tooltips_.emplace_back(point, tooltip);
     }
 
@@ -138,7 +138,7 @@ class CustomPlotPicker : public QwtPlotPicker {
 };
 
 
-astigStatsDlg::astigStatsDlg(QVector<wavefront *> wavefronts, QWidget *parent) :
+astigStatsDlg::astigStatsDlg(const QVector<wavefront *> &wavefronts, QWidget *parent) :
     QDialog(parent),
     ui(new Ui::astigStatsDlg), m_wavefronts(wavefronts), editor(0), PDFMode(false),
     distributionWindow(0), runningAvgN(20), showSamples(false),
@@ -181,7 +181,7 @@ class measure{
 public:
     QString name;
     QPointF p;
-    measure(QString n, QPointF _p):name(n),p(_p){};
+    measure(const QString &n, QPointF _p):name(n),p(_p){};
     measure(){};
 };
 
@@ -480,7 +480,7 @@ void astigStatsDlg::plot(){
     ui->mPlot->replot();
 }
 
-void astigStatsDlg::showItem(QVariant item, bool on, int /*ndx*/){
+void astigStatsDlg::showItem(const QVariant &item, bool on, int /*ndx*/){
     qDebug() << "item " << item;
     QwtPlotItem *t = qvariant_cast<QwtPlotItem *>(item);
     t->setVisible(on);

astigstatsdlg.h

@@ -24,7 +24,7 @@ class astigStatsDlg : public QDialog
     Q_OBJECT
 
 public:
-    explicit astigStatsDlg( QVector<wavefront *> wavefronts,QWidget *parent = 0);
+    explicit astigStatsDlg( const QVector<wavefront *> &wavefronts,QWidget *parent = 0);
     ~astigStatsDlg();
     void plot();
 private slots:
@@ -41,7 +41,7 @@ private slots:
     void on_clearPb_clicked();
 
     void on_onlyAverages_clicked();
-    void showItem(QVariant item, bool on, int ndx);
+    void showItem(const QVariant &item, bool on, int ndx);
 
     void on_savePB_clicked();
     void showSamplesChanged(bool);

averagewavefrontfilesdlg.cpp

@@ -10,7 +10,7 @@
 #include <opencv2/imgproc.hpp>
 
 void showData(const std::string &txt, cv::Mat mat, bool useLog);
-averageWaveFrontFilesDlg::averageWaveFrontFilesDlg(QStringList list, SurfaceManager *m, QWidget *parent) :
+averageWaveFrontFilesDlg::averageWaveFrontFilesDlg(const QStringList &list, SurfaceManager *m, QWidget *parent) :
     QDialog(parent),
     ui(new Ui::averageWaveFrontFilesDlg)
 {

averagewavefrontfilesdlg.h

@@ -16,7 +16,7 @@ class averageWaveFrontFilesDlg : public QDialog
     SurfaceManager *sm;
 
 public:
-    explicit averageWaveFrontFilesDlg(QStringList list, SurfaceManager *sm, QWidget *parent = 0);
+    explicit averageWaveFrontFilesDlg(const QStringList &list, SurfaceManager *sm, QWidget *parent = 0);
     ~averageWaveFrontFilesDlg();
     wavefront *average;
 signals:

batchigramwizard.cpp

@@ -27,7 +27,7 @@ QString batchIgramWizard::reviewFileName;
 QCheckBox *batchIgramWizard::autoOutlineCenter = 0;
 QCheckBox *batchIgramWizard::autoOutlineOutside = 0;
 
-batchIgramWizard::batchIgramWizard(QStringList files, QWidget *parent, Qt::WindowFlags flags) :
+batchIgramWizard::batchIgramWizard(const QStringList &files, QWidget *parent, Qt::WindowFlags flags) :
     QWizard(parent, flags),
     ui(new Ui::batchIgramWizard)
 {
@@ -88,7 +88,7 @@ void batchIntro::eraseItem()
     }
 }
 
-void batchIntro::showContextMenu(const QPoint &pos)
+void batchIntro::showContextMenu(QPoint pos)
 {
     // Handle global position
     QPoint globalPos = filesList->mapToGlobal(pos);
@@ -257,7 +257,7 @@ bool batchIntro::shouldFilterWavefront(double rms){
     return (filterWavefront && rms > filterRms);
 }
 
-void batchIgramWizard::addAstig(QString name, QPointF value){
+void batchIgramWizard::addAstig(const QString &name, QPointF value){
 
     introPage->astigPlot->addValue(name,value);
 }
@@ -267,7 +267,7 @@ void batchIgramWizard::progressValue(int min, int max, int value){
     introPage->pgrBar->setValue(value);
 }
 
-void batchIgramWizard::addRms(QString name, QPointF p){
+void batchIgramWizard::addRms(const QString &name, QPointF p){
     introPage->m_rmsPlot->addValue(name,p);
 }