From 2d8d4e09dd5d2d378e79209cad7136aa62bb795a Mon Sep 17 00:00:00 2001
From: gr5 <gr@gr5.org>
Date: Thu, 8 Jan 2026 12:54:00 -0500
Subject: [PATCH 1/2] Fixed bug in foucault/ronchi view where it was always in
 "autocollimate" mode

---
 RevisionHistory.html |  5 +++++
 foucaultview.cpp     | 16 ++++++++++++----
 foucaultview.h       |  2 +-
 3 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/RevisionHistory.html b/RevisionHistory.html
index bc2bef41..dca46a17 100644
--- a/RevisionHistory.html
+++ b/RevisionHistory.html
@@ -10,6 +10,11 @@
     <h1>DFTFringe Version History</h1>
     <ul>
 
+        <li>Version 8.3.2</li>
+        <ul>
+            <li>Fixed bug introduced in 8.3.1 in ronchi foucault where it was always doing autocollimate mode</li>
+        </ul>
+
         <li>Version 8.3.1</li>
         <ul>
             <li>Auto-invert feature (and dialog) only applies to wavefronts created form igram, not those loaded from file, simulated, averaged, subtracted, etc.</li>
diff --git a/foucaultview.cpp b/foucaultview.cpp
index e17212ef..4a4aa615 100644
--- a/foucaultview.cpp
+++ b/foucaultview.cpp
@@ -171,7 +171,7 @@ QVector<QPoint> scaleProfile(QPolygonF points, int width,
 }
 
 
-QImage foucaultView::generateOpticalTestImage(OpticalTestType type, wavefront* wf, const OpticalTestSettings& s)
+QImage foucaultView::generateOpticalTestImage(OpticalTestType type, wavefront* wf, const OpticalTestSettings& s, bool bAutoCollimate)
 {
     if (!wf || wf->data.cols == 0) return QImage();
 
@@ -200,8 +200,15 @@ QImage foucaultView::generateOpticalTestImage(OpticalTestType type, wavefront* w
 
     SimulationsView *sv = SimulationsView::getInstance(0);
     sv->setSurface(wf);
+
+    bool oldDoNull = md->doNull;
+    if (bAutoCollimate == false)
+        md->doNull = false; // this is normal foucault/ronchi so we *don't* subtract the null (autcoCollimate ronchi or foucault mode will typically subtract the null)
+
     cv::Mat surf_fft = sv->computeStarTest(s.heightMultiply * sv->nulledSurface(effectiveZ3), size, actualPad, true);
+
     wf->InputZerns = originalZerns; // Restore state immediately
+    md->doNull = oldDoNull;
 
     // 3. Mask Generation
     cv::Mat mask = cv::Mat::zeros(size, size, CV_64FC1);
@@ -275,6 +282,7 @@ void foucaultView::on_makePb_clicked()
 
     QApplication::setOverrideCursor(Qt::WaitCursor);
 
+
     // 1. Pack the current UI state into the settings struct
     OpticalTestSettings settings;
     settings.rocOffset    = ui->rocOffsetSb->value();
@@ -293,8 +301,8 @@ void foucaultView::on_makePb_clicked()
     settings.outputLambda   = outputLambda;
 
     // 2. Call the refactored static engine for both images
-    QImage ronchiImg = generateOpticalTestImage(OpticalTestType::Ronchi, m_wf, settings);
-    QImage foucaultImg = generateOpticalTestImage(OpticalTestType::Foucault, m_wf, settings);
+    QImage ronchiImg = generateOpticalTestImage(OpticalTestType::Ronchi, m_wf, settings, ui->autocollimation->isChecked());
+    QImage foucaultImg = generateOpticalTestImage(OpticalTestType::Foucault, m_wf, settings, ui->autocollimation->isChecked());
 
     // Store for potential saving/external access
     m_foucaultQimage = foucaultImg;
@@ -402,7 +410,7 @@ void foucaultView::generateBatchRonchiImage(const QList<wavefront*>& wavefrontLi
         int row = i / cols;
         int col = i % cols;
 
-        QImage ronchi = generateOpticalTestImage(OpticalTestType::Ronchi, currentWf, s);
+        QImage ronchi = generateOpticalTestImage(OpticalTestType::Ronchi, currentWf, s, ui->autocollimation->isChecked());
 
         if (!ronchi.isNull()) {
             // Store a copy for the comparison feature
diff --git a/foucaultview.h b/foucaultview.h
index 83336188..205c04a1 100644
--- a/foucaultview.h
+++ b/foucaultview.h
@@ -52,7 +52,7 @@ class foucaultView : public QWidget
     bool needsDrawing;
 
     // The Refactored Static Engine - Callable from other classes
-    static QImage generateOpticalTestImage(OpticalTestType type, wavefront* wf, const OpticalTestSettings& settings);
+    static QImage generateOpticalTestImage(OpticalTestType type, wavefront* wf, const OpticalTestSettings& settings, bool bAutoCollimate);
 
 public slots:
     void on_makePb_clicked();

From e8d4dc25b1bb3e1a423567fa1a67e5dd70e1958b Mon Sep 17 00:00:00 2001
From: gr5 <gr5@users.noreply.github.com>
Date: Thu, 8 Jan 2026 14:29:23 -0500
Subject: [PATCH 2/2] Update RevisionHistory.html

Co-authored-by: Julien Staub <atsju2@yahoo.fr>
---
 RevisionHistory.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/RevisionHistory.html b/RevisionHistory.html
index dca46a17..a17bf02b 100644
--- a/RevisionHistory.html
+++ b/RevisionHistory.html
@@ -12,7 +12,7 @@ <h1>DFTFringe Version History</h1>
 
         <li>Version 8.3.2</li>
         <ul>
-            <li>Fixed bug introduced in 8.3.1 in ronchi foucault where it was always doing autocollimate mode</li>
+            <li>Fixed bug introduced in 8.3.1 in Ronchi Foucault where it was always doing autocollimate mode</li>
         </ul>
 
         <li>Version 8.3.1</li>