Remove duplicate code for YAML conversion in workflow engines (#2830)

* Initial plan

* Initial analysis - understanding duplication

Co-authored-by: pelikhan <[email protected]>

* Changes before error encountered

Co-authored-by: pelikhan <[email protected]>

* Complete duplicate code removal - all tests passing

Co-authored-by: pelikhan <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: pelikhan <[email protected]>

Author: Copilot

.github/workflows/go-logger.lock.yml

@@ -171,6 +171,12 @@ func (e *BaseEngine) GetLogFileForParsing() string {
 	return "/tmp/gh-aw/agent-stdio.log"
 }
 
+// convertStepToYAML converts a step map to YAML string - uses proper YAML serialization
+// This is a shared implementation inherited by all engines that embed BaseEngine
+func (e *BaseEngine) convertStepToYAML(stepMap map[string]any) (string, error) {
+	return ConvertStepToYAML(stepMap)
+}
+
 // EngineRegistry manages available agentic engines
 type EngineRegistry struct {
 	engines map[string]CodingAgentEngine

.github/workflows/technical-doc-writer.lock.yml

@@ -287,11 +287,6 @@ func (e *ClaudeEngine) GetExecutionSteps(workflowData *WorkflowData, logFile str
 	return steps
 }
 
-// convertStepToYAML converts a step map to YAML string - uses proper YAML serialization
-func (e *ClaudeEngine) convertStepToYAML(stepMap map[string]any) (string, error) {
-	return ConvertStepToYAML(stepMap)
-}
-
 // GetLogParserScriptId returns the JavaScript script name for parsing Claude logs
 func (e *ClaudeEngine) GetLogParserScriptId() string {
 	return "parse_claude_log"

.github/workflows/tidy.lock.yml

@@ -172,11 +172,6 @@ codex %sexec%s%s%s"$INSTRUCTION" 2>&1 | tee %s`, modelParam, webSearchParam, ful
 	return steps
 }
 
-// convertStepToYAML converts a step map to YAML string - uses proper YAML serialization
-func (e *CodexEngine) convertStepToYAML(stepMap map[string]any) (string, error) {
-	return ConvertStepToYAML(stepMap)
-}
-
 // expandNeutralToolsToCodexTools converts neutral tools to Codex-specific tools format
 // This ensures that playwright tools get the same allowlist as the copilot agent
 func (e *CodexEngine) expandNeutralToolsToCodexTools(tools map[string]any) map[string]any {

.github/workflows/unbloat-docs.lock.yml

@@ -328,11 +328,6 @@ COPILOT_CLI_INSTRUCTION=$(cat /tmp/gh-aw/aw-prompts/prompt.txt)
 	return steps
 }
 
-// convertStepToYAML converts a step map to YAML string - uses proper YAML serialization
-func (e *CopilotEngine) convertStepToYAML(stepMap map[string]any) (string, error) {
-	return ConvertStepToYAML(stepMap)
-}
-
 // GetSquidLogsSteps returns the steps for collecting and uploading Squid logs
 func (e *CopilotEngine) GetSquidLogsSteps(workflowData *WorkflowData) []GitHubActionStep {
 	var steps []GitHubActionStep

pkg/workflow/agentic_engine.go

@@ -137,11 +137,6 @@ func (e *CustomEngine) GetExecutionSteps(workflowData *WorkflowData, logFile str
 	return steps
 }
 
-// convertStepToYAML converts a step map to YAML string - uses proper YAML serialization
-func (e *CustomEngine) convertStepToYAML(stepMap map[string]any) (string, error) {
-	return ConvertStepToYAML(stepMap)
-}
-
 // RenderMCPConfig renders MCP configuration using shared logic
 func (e *CustomEngine) RenderMCPConfig(yaml *strings.Builder, tools map[string]any, mcpTools []string, workflowData *WorkflowData) {
 	// Use shared JSON MCP config renderer