Simplify boolean inputs

Author: ageorgou

action.yml

@@ -24,11 +24,13 @@ inputs:
     description: "The branch name to push the diagram to (branch will be created if it does not yet exist). For example: diagram"
     required: false
   push:
-    description: "Whether to push the new commit back to the repository. Default: true"
+    description: "Whether to push the new commit back to the repository. Must be true or false. Default: true"
     required: false
+    default: true
   upload:
-    description: "Whether to upload the new diagram as an artiface. Default: false"
+    description: "Whether to upload the new diagram as an artiface. Must be true or false. Default: false"
     required: false
+    default: false
 runs:
   using: "node12"
   main: "index.js"

src/index.jsx

@@ -68,7 +68,7 @@ const main = async () => {
     return
   }
 
-  const shouldPush = getAsBoolean(core.getInput('push'), true)
+  const shouldPush = core.getBooleanInput('push')
   if (shouldPush) {
     core.startGroup('Commit and push diagram')
     await exec('git', ['commit', '-m', commitMessage])
@@ -85,7 +85,7 @@ const main = async () => {
     core.endGroup()
   }
 
-  const shouldUpload = getAsBoolean(core.getInput('upload'), false)
+  const shouldUpload = core.getBooleanInput('upload')
   if (shouldUpload) {
     core.startGroup('Upload diagram to artifacts')
     const client = artifact.create()
@@ -125,7 +125,3 @@ function execWithOutput(command, args) {
     }
   })
 }
-
-function getAsBoolean(option, defaultValue) {
-  return option === '' ? defaultValue : (option.toLowerCase() === 'true')
-}