Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Commit e6c7ff8

Browse files
committed
bring together the bucket creation with the aws-config file
1 parent c4ee8de commit e6c7ff8

File tree

3 files changed

+16
-14
lines changed

3 files changed

+16
-14
lines changed

config.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,9 @@ steps:
158158

159159
# event: responding with a comment
160160

161-
- title: Confirm AWS S3 configuration
162-
description: Create an AWS account by the following specifications, and confirm here
163-
event: issue_comment.created
161+
- title: Create an S3 bucket
162+
description: Create an S3 bucket in AWS and tell the action where to find it
163+
event: pull_request.synchronize
164164
link: '{{ repoUrl }}/pull/2'
165165
actions:
166166

responses/03_workflow-steps.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ The course [_Using GitHub Actions for CI_](https://lab.github.com/githubtraining
1616
### :keyboard: Activity: Deploy a Node.js app to AWS for the first time
1717

1818
1. In a new tab, [create an AWS account](https://portal.aws.amazon.com/billing/signup) if you don't already have one.
19-
> Note: You may need a credit card to create an AWS account. If you're a student, you may also be able to take advantage of the [Student Developer Pack](https://education.github.com/pack) for access to AWS.
19+
> Note: You may need a credit card to create an AWS account. If you're a student, you may also be able to take advantage of the [Student Developer Pack](https://education.github.com/pack) for access to AWS. If you'd like to continue with the course without an AWS account, Learning Lab will still respond, but none of the deployments will work.
2020
1. **[Add a user](https://console.aws.amazon.com/iam/home?#/users$new?step=details)** in the IAM service with administrator permission.
2121
- For detailed instructions on adding users, see [_Creating an IAM User in Your AWS Account_](https://docs.aws.amazon.com/IAM/latest/UserGuide/id_users_create.html) in the AWS docs.
2222
1. In the confirmation screen, copy both the **Access key ID** and the **Secret access key** to a safe space. We'll use these in the next few steps as follows:

responses/05_confirm-aws.md

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,22 @@
11
# AWS Configuration - S3 Buckets
22

3-
For deployment, we will be using AWS.
3+
GitHub Actions is cloud agnostic, so any cloud will work. We'll show how to deploy to AWS in this course.
44

55
### S3 Buckets
66

7-
Amazon S3 Buckets are containers. They're also a very flexible type of data storage- they can be configured to work in many different types of ways. They're popular for their security, scalability, and dependability. Our S3 Bucket will be the container that our application is deployed in, both in staging and in production.
7+
Amazon S3 Buckets are a very flexible type of data storage -- they can be configured to work in many different types of ways. They're popular for their security, scalability, and dependability. Our S3 Bucket will store our application, both in staging and in production.
88

99
## Step 5: Confirm AWS S3 configuration
1010

1111
### :keyboard: Activity: Create an AWS account by the following specifications, and confirm here
1212

13-
1. Create an account at [aws.amazon.com](https://aws.amazon.com/)
14-
- _This requires credit card information. If you'd like to continue with the course without an AWS account, Learning Lab will still respond, but none of the deployments will work._
15-
2. [Create an S3 bucket](https://docs.aws.amazon.com/AmazonS3/latest/gsg/CreatingABucket.html)
16-
- If you aren't sure how to get there, you can search for `S3`.
17-
- Name the bucket `github-sam-test`
18-
- The region needs to be the same as what is specified in the `aws-config.yml` file in this pull request. :eyes: **For this exercise, choose us-west-2**. :eyes: If you'd like to choose another region, make sure to update the `aws-config.yml` file to match.
19-
- For all other options, accept the defaults.
20-
3. Confirm that you've created an S3 bucket by commenting anything in this pull request
13+
1. Navigate to the [Amazon S3](https://s3.console.aws.amazon.com/s3/home) service and click on **Create bucket**.
14+
- See [_Create a Bucket_](https://docs.aws.amazon.com/AmazonS3/latest/gsg/CreatingABucket.html) on AWS documentation for the most detailed instructions.
15+
1. Name the bucket whatever you'd like, and jot the name down
16+
1. Select a region, and jot it down. You'll need it later. These examples use **us-west-2**. If you'd like to choose another region, make sure to update the `aws-config.yml` file to match.
17+
1. For all other options, accept the defaults.
18+
1. In `.github/aws-config.yml` on this branch, change the value of `s3_bucket:` to match your chosen bucket name.
19+
1. In the same file, confirm that the `region:` value matches your chosen region for the S3 bucket.
20+
1. Commit your changes.
21+
22+
I'll respond when I detect a commit on this branch.

0 commit comments

Comments
 (0)