Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Commit e00327a

Browse files
authored
Merge pull request #5 from githubtraining/monday-edits
Monday Edits
2 parents 388f367 + a87f257 commit e00327a

File tree

7 files changed

+28
-16
lines changed

7 files changed

+28
-16
lines changed

config.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,8 @@ steps:
100100
event: APPROVE
101101
body: 04-merge-first-pr.md
102102

103-
- title: Merge your first Pull Request
104-
description: Merge your Pull Request
103+
- title: Merge your first pull request
104+
description: Merge your pull request
105105
event: pull_request.closed
106106
link: https://github.com/{{ user.username }}/{{ course.template.name }}/pulls
107107
actions:
@@ -178,8 +178,8 @@ steps:
178178
body: 07-merge-second-pr.md
179179
event: APPROVE
180180

181-
- title: Merge your second Pull Request
182-
description: Merge your Pull Request
181+
- title: Merge your second pull request
182+
description: Merge your pull request
183183
event: pull_request.closed
184184
link: https://github.com/{{ user.username }}/{{ course.template.name }}/pulls
185185
actions:
@@ -260,8 +260,8 @@ steps:
260260
body: 10-merge-third-pr.md
261261
event: APPROVE
262262

263-
- title: Merge your third Pull Request
264-
description: Merge your Pull Request
263+
- title: Merge your third pull request
264+
description: Merge your pull request
265265
event: pull_request.closed
266266
link: https://github.com/{{ user.username }}/{{ course.template.name }}/pulls
267267
actions:
@@ -299,7 +299,7 @@ steps:
299299
- type: respond
300300
with: 11-style-success.md
301301

302-
- title: Merge the final Pull Request
302+
- title: Merge the final pull request
303303
description: Get ready to show off your new skills
304304
event: pull_request.closed
305305
link: https://github.com/{{ user.username }}/{{ course.template.name }}/pulls

responses/00-openapr.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ It's not very special looking yet, is it? Web hosts (and GitHub Pages) look for
88

99
To help you get started, I have already created an `index.html` file for you on a branch called: `add-index`. All you need to do is create the pull request:
1010

11-
1. Create a pull request. You can either [use this direct link](https://github.com/{{ user.username }}/{{ repo }}/compare/master...add-index?expand=1), or go to the "Code" tab, click on **New Pull Request**, select **base: master**, and **compare: add-index**.
11+
1. Create a pull request. You can either [use this direct link](https://github.com/{{ user.username }}/{{ repo }}/compare/master...add-index?expand=1), or go to the **Code** tab, click on **New Pull Request**, select **base: master**, and **compare: add-index**.
1212
1. Add a descriptive title to your pull request, something like "Add the index.html file".
13-
1. Add a descriptive body to you pull request.
13+
1. Add a descriptive body to your pull request.
1414
1. Click **Create pull request**.
1515

1616
<hr>

responses/05-h1-tag.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Headers create prominent text in the body of your web page. Headers come in diff
1212

1313

1414
1. Edit the `index.html` file in your master branch by [using this direct link](https://github.com/{{ user.username }}/{{ repo }}/edit/master/index.html) or going to the **Code** tab, clicking on the `index.html` file, clicking the pencil :pencil: to edit the HTML.
15-
1. Inside the body tag, add an opening `<h1>` tag, some content for the header, and a closing `</h1>` tag.
15+
1. Between the body tags, add an opening `<h1>` tag, some content for the header, and a closing `</h1>` tag.
1616
1. In the _Commit changes_ section, enter a commit message that describes what you've done.
1717
1. Ensure you've selected _Create a new branch for this commit and start a pull request_.
1818
1. Give your branch a descriptive name, like `add-headers-and-images`.

responses/06-add-image.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ You'll also notice that the image tag doesn't need to close since it is consider
1414

1515
1. Click on **Files Changed**.
1616
1. Click on the :pencil: to edit the file.
17-
1. Place an opening `<img>` tag inside the body tag.
17+
1. Place an opening `<img>` tag between the body tags. Reminder: you don't need to close an `<img>` tag!
1818
1. Set the `src` attribute to the image you would like to display. You can use your GitHub profile picture: `{{ user.avatarUrl }}`
1919
1. In the _Commit changes_ section, enter a commit message that describes what you've done.
2020
1. Click on **Commit changes**.

responses/06e-image.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
I didn't find the image! Here are some troubleshooting steps:
22

3-
1. Check your spelling. We're checking specifically for the image, `<img>`, tag with a source attribute: `<img src="{{avatar}}">`
3+
1. Check your spelling. We're checking specifically for the image, `<img>`, tag with a source attribute: `<img src="`{{ user.avatarUrl }}`">`
44
3. Make sure you placed the image tag inside the body tags.
55
4. Ensure you modified the `index.html` file, and not some other file.
66

@@ -11,6 +11,6 @@ Let's try again!
1111
1. Click on **Files Changed**.
1212
1. Click on the :pencil: to edit the file.
1313
1. Place an opening `<img>` tag inside the body tag.
14-
1. Set the `src` attribute to your GitHub profile picture: `{{ avatar }}`
14+
1. Set the `src` attribute to your GitHub profile picture: ``{{ user.avatarUrl }}``
1515
1. In the _Commit changes_ section, enter a commit message that describes what you've done.
16-
1. Click on **Commit changes**.
16+
1. Click on **Commit changes**.

responses/09-add-links.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,12 @@ Hyperlinks allow people to navigate through pages on the web. Links are achieved
1818

1919
1. Click on **Files Changed**.
2020
1. Click on the :pencil: pencil icon to edit the file.
21-
1. Link each of your favorite sites to their respective URLs. You can do this by adding an opening anchor tag `<a>` tag with `href` attribute with your favorite site's URL, the name of the site inside the anchor tag, and a closing anchor `</a>` tag.
21+
1. In the list you just created, add a link to each of your favorite sites to their respective URLs. You can do this by adding an opening anchor tag `<a>` tag with `href` attribute with your favorite site's URL, the name of the site inside the anchor tag, and a closing anchor `</a>` tag. Here is an example of a list item with a link:
22+
23+
```html
24+
<li><a href="https://github.com">This is a link to GitHub!</a></li>
25+
```
26+
2227
1. In the _Commit changes_ section, enter a commit message that describes what you've done.
2328
1. Click on **Commit changes**.
2429

responses/12-big-finish.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,14 @@
22

33
Well done @{{ user.username }}, here is the finished result: https://{{user.username}}.github.io/{{repo}}/
44

5-
You've learned the basics of HTML, and used it to build a simple webpage. If you'd like, you can make your fancy new page the default start page for your web browser. Just follow the links below for more information:
5+
You've learned the basics of HTML, and used it to build a simple webpage.
6+
7+
Though this works, there's still more you can do to make sure you're up to date with standard conventions, like using an HTML validator.
8+
9+
Here's an example, using your current website: https://validator.w3.org/nu/?showsource=yes&doc=https://{{user.username}}.github.io/{{repo}}/
10+
11+
12+
If you'd like, you can make your fancy new page the default start page for your web browser. Just follow the links below for more information:
613

714
- [Google Chrome](https://support.google.com/chrome/answer/95314?hl=en)
815
- [Safari](https://support.apple.com/guide/safari/set-your-homepage-ibrw1020/mac)

0 commit comments

Comments
 (0)