Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Step 7 has a lot of extraneous lines in diff #130

@amyschoen

Description

@amyschoen

Bug Report

Current behavior
I'm seeing a lot of extra lines come up in the diff due to spacing differences in engine.js and game.js.

Screen Shot 2020-02-10 at 1 08 23 PM

Reproduction
Steps to reproduce the behavior in the course:

  1. Take the course until you get to step 7.
  2. Take a look at the diff for the review.
  3. You'll see a lot of extra lines flagged in the diff due to a space or lack thereof.

Expected behavior
I would expect the diff to show the new file (.github/release-drafter.yml) and only the changes to make the text green.

Possible solution
Clean up the files on the green-colors branch.

Additional context
GHES v2.19.6, LL v0.6.0

/cc @crichID @brianamarie @hectorsector @JasonEtco

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions