Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Commit 5b5aa6c

Browse files
committed
fixes based on qa for links and clarity
1 parent 5adbd04 commit 5b5aa6c

File tree

9 files changed

+17
-14
lines changed

9 files changed

+17
-14
lines changed

config.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ steps:
4545
with: 02_closed-issue.md
4646
data:
4747
url: '%actions.issue.data.html_url%'
48-
pages: 'https://%payload.repository.owner.login%.github.io/%payload.repository.name%'
48+
pages: 'https://%payload.repository.owner.login%.github.io/%payload.repository.name%' #TODO Fix link
4949

5050
- title: Find the vulnerable dependency
5151
description: Find the vulnerable dependency, and comment with the suggested update version.
@@ -55,7 +55,7 @@ steps:
5555
- type: respond
5656
with: 03_found-vulnerability.md
5757
data:
58-
url: 'https://github.com/%payload.repository.owner.login%/%payload.repository.name%/pull/1'
58+
url: '{{ repoUrl }}/pull/1'
5959
- type: closeIssue
6060
issue: Find repository vulnerabilities
6161

@@ -99,7 +99,7 @@ steps:
9999
- type: respond
100100
with: 04a_good-merge.md
101101
data:
102-
url: 'https://github.com/%payload.repository.owner.login%/%payload.repository.name%/pull/3'
102+
url: '{{ repoUrl }}/pull/3'
103103

104104
- title: Add to the `.gitignore` file
105105
description: The `.gitignore` file is ready to be edited in an open pull request. Add the `.env` file to the `.gitignore` file.
@@ -140,7 +140,7 @@ steps:
140140
title: Congratulations!
141141
body: 06b_final-issue.md
142142
data:
143-
url: 'https://%user.username%.github.io/%payload.repository.name%'
143+
url: 'https://%user.username%.github.io/%payload.repository.name%' #TODO Fix URL
144144
action_id: finalIssue
145145
- type: respond
146146
with: 06a_nice-merge.md

responses/01a_class-introduction-issue.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ This project is centered around a memory game that will be deployed with GitHub
2525
### :keyboard: Activity: Enable vulnerability alerts & GitHub Pages
2626

2727

28-
1. Click the **Settings** tab in your repository.
28+
1. Click the [**Settings**]({{ repoUrl }}/settings) tab in your repository.
2929
1. Scroll down until you see **Data services**.
3030
1. Under **Data services**, click the check boxes to enable all the data services.
3131
1. Scroll down to **GitHub Pages**. Select `master` as a **Source**, and click **Save**.
@@ -47,6 +47,6 @@ For a printable version of the steps in this course, check out the [Quick Refere
4747
> Turning on GitHub Pages creates a deployment of your repository. I may take up to a minute to respond as I await the deployment.
4848
4949
<hr>
50-
<h3 align="center">Return to this issue for my next comment</h3>
50+
<h3 align="center">Return to this issue for my next comment.</h3>
5151

5252
> _Sometimes I respond too fast for the page to update! If you perform an expected action and don't see a response from me, wait a few seconds. Then refresh the page for your next steps._

responses/02_closed-issue.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
Great work. Make sure to complete the first few steps in your settings. Then, you should be able to see your published [memory game on GitHub Pages]({{ pages }}).
22

33
<hr>
4-
<h3 align="center">I've opened <a href="{{ url }}">another issue with the next steps</a></h3>
4+
<h3 align="center">I've opened <a href="{{ url }}">another issue with the next steps.</a></h3>

responses/02_find-vulnerabilities.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,16 @@ Use GitHub's security alerts to identify a vulnerable NPM dependency.
2828

2929
### :keyboard: Activity: Identify the suggested version update
3030

31-
1. Click the **Insights** tab in your repository
31+
1. Click the [**Insights**]({{ repoUrl }}/insights) tab in your repository
3232
1. On the left hand navigation bar, click **Dependency graph**
3333
1. Scroll down until you see a yellow bar highlighting the dependency named `debug`, and click on the right hand side of the yellow `debug` section
3434
1. Take note of the suggested version
3535
1. Comment in this issue with the suggested update version
3636

37+
38+
> _**GitHub Enterprise Server only:** This is all possible on GitHub Enterprise through GitHub Connect. It may take up to an hour to refresh the alerts and make them visible. After waiting a reasonable amount of time, if you are still not seeing the yellow bar in the Dependency Graph, you may want to contact your administrator. In the mean time, to move along with the course, we'll give you a hint - the recommended upgraded version is `2.6.9`._
39+
3740
For a printable version of the steps in this course, check out the [Quick Reference Guide]({{ host }}/public/{{ course.slug }}.pdf).
3841

3942
<hr>
40-
<h3 align="center">Return to this issue for my next comment</h3>
43+
<h3 align="center">Return to this issue for my next comment.</h3>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
Nice work!
22

33
<hr>
4-
<h3 align="center">I've opened <a href="{{ url }}">a pull request with your next steps</a></h3>
4+
<h3 align="center">I've opened <a href="{{ url }}">a pull request with your next steps.</a></h3>

responses/04a_good-merge.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
Nice job merging @{{ user.username }}. Go ahead and delete the branch.
22

33
<hr>
4-
<h3 align="center">Let's learn about <code>.gitignore</code> files in the <a href="{{ url }}">next pull request</a></h3>
4+
<h3 align="center">Let's learn about <code>.gitignore</code> files in the <a href="{{ url }}">next pull request.</a></h3>

responses/04b_add-gitignore.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@ In this pull request, I'm adding a `.gitignore` file. Files ending with `.env` c
2424
For a printable version of the steps in this course, check out the [Quick Reference Guide]({{ host }}/public/{{ course.slug }}.pdf).
2525

2626
<hr>
27-
<h3 align="center">Return to this pull request for my next comment</h3>
27+
<h3 align="center">Return to this pull request for my next comment.</h3>
2828

2929
> _Sometimes I respond too fast for the page to update! If you perform an expected action and don't see a response from me, wait a few seconds. Then refresh the page for your next steps._

responses/06a_nice-merge.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
Congratulations, you've done it @{{ user.username }}! Go ahead and delete the branch.
22

33
<hr>
4-
<h3 align="center">Find your final issue <a href="{{ url }}">here</a> now</h3>
4+
<h3 align="center">Find your final issue <a href="{{ url }}">here</a> now.</h3>

responses/06b_final-issue.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,4 @@ Want to learn more options to secure your repository? Check out the [documentati
2929
Want to keep learning? Feel free to [check out our other courses]({{ host }}/courses).
3030

3131
<hr>
32-
<h3 align="center">I won't respond to this issue, go ahead and close it when finished</h3>
32+
<h3 align="center">I won't respond to this issue, go ahead and close it when finished.</h3>

0 commit comments

Comments
 (0)