Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Commit b4e3dd5

Browse files
authored
Revert "Fixes based on qa for links and clarity"
1 parent 4554313 commit b4e3dd5

13 files changed

+34
-41
lines changed

config.yml

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -40,17 +40,12 @@ steps:
4040
action_id: issue
4141
- type: closeIssue
4242
issue: Welcome
43-
- type: octokit
44-
method: repos.getPages
45-
owner: '%payload.repository.owner.login%'
46-
repo: '%payload.repository.name%'
47-
action_id: pagesUrl
4843
- type: respond
4944
issue: Welcome
5045
with: 02_closed-issue.md
5146
data:
5247
url: '%actions.issue.data.html_url%'
53-
pages: '%actions.pagesUrl.data.html_url%'
48+
pages: 'https://%payload.repository.owner.login%.github.io/%payload.repository.name%'
5449

5550
- title: Find the vulnerable dependency
5651
description: Find the vulnerable dependency, and comment with the suggested update version.
@@ -59,6 +54,8 @@ steps:
5954
actions:
6055
- type: respond
6156
with: 03_found-vulnerability.md
57+
data:
58+
url: 'https://github.com/%payload.repository.owner.login%/%payload.repository.name%/pull/1'
6259
- type: closeIssue
6360
issue: Find repository vulnerabilities
6461

@@ -101,6 +98,8 @@ steps:
10198
- type: updateBranchProtection
10299
- type: respond
103100
with: 04a_good-merge.md
101+
data:
102+
url: 'https://github.com/%payload.repository.owner.login%/%payload.repository.name%/pull/3'
104103

105104
- title: Add to the `.gitignore` file
106105
description: The `.gitignore` file is ready to be edited in an open pull request. Add the `.env` file to the `.gitignore` file.
@@ -137,16 +136,11 @@ steps:
137136
number: '%payload.repository.pull_request.number%'
138137
- type: respond
139138
with: 05_early-close.md
140-
- type: octokit
141-
method: repos.getPages
142-
owner: '%payload.repository.owner.login%'
143-
repo: '%payload.repository.name%'
144-
action_id: pagesUrl
145139
- type: createIssue
146140
title: Congratulations!
147141
body: 06b_final-issue.md
148142
data:
149-
url: '%actions.pagesUrl.data.html_url%'
143+
url: 'https://%user.username%.github.io/%payload.repository.name%'
150144
action_id: finalIssue
151145
- type: respond
152146
with: 06a_nice-merge.md

responses/01a_class-introduction-issue.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ This project is centered around a memory game that will be deployed with GitHub
2525
### :keyboard: Activity: Enable vulnerability alerts & GitHub Pages
2626

2727

28-
1. Click the [**Settings**]({{ repoUrl }}/settings) tab in your repository.
28+
1. Click the **Settings** tab in your repository.
2929
1. Scroll down until you see **Data services**.
3030
1. Under **Data services**, click the check boxes to enable all the data services.
3131
1. Scroll down to **GitHub Pages**. Select `master` as a **Source**, and click **Save**.
@@ -35,16 +35,18 @@ This project is centered around a memory game that will be deployed with GitHub
3535
### :keyboard: Activity: Enable GitHub Pages
3636

3737

38-
1. Click the [**Settings**]({{ repoUrl }}/settings) tab in your repository.
38+
1. Click the **Settings** tab in your repository.
3939
1. Scroll down to **GitHub Pages**. Select `master` as a **Source**, and click **Save**.
4040

4141
{% endif %}
4242

43+
44+
4345
For a printable version of the steps in this course, check out the [Quick Reference Guide]({{ host }}/public/{{ course.slug }}.pdf).
4446

4547
> Turning on GitHub Pages creates a deployment of your repository. I may take up to a minute to respond as I await the deployment.
4648
4749
<hr>
48-
<h3 align="center">Return to this issue for my next comment.</h3>
50+
<h3 align="center">Return to this issue for my next comment</h3>
4951

5052
> _Sometimes I respond too fast for the page to update! If you perform an expected action and don't see a response from me, wait a few seconds. Then refresh the page for your next steps._

responses/02_closed-issue.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
Great work. Make sure to complete the first few steps in your settings. Then, you should be able to see your published [memory game on GitHub Pages]({{ pages }}).
22

33
<hr>
4-
<h3 align="center">I've opened <a href="{{ url }}">another issue with the next steps.</a></h3>
4+
<h3 align="center">I've opened <a href="{{ url }}">another issue with the next steps</a></h3>

responses/02_find-vulnerabilities.md

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,16 +28,13 @@ Use GitHub's security alerts to identify a vulnerable NPM dependency.
2828

2929
### :keyboard: Activity: Identify the suggested version update
3030

31-
1. Click the **Insights** tab in your repository.
32-
2. On the left hand navigation bar, click **Dependency graph**.
33-
3. Scroll down until you see a yellow bar highlighting the dependency named `debug`, and click on the right hand side of the yellow `debug` section.
34-
4. Take note of the suggested version.
35-
5. Comment in this issue with the suggested update version.
36-
37-
38-
> _**GitHub Enterprise Server only:** This is all possible on GitHub Enterprise through GitHub Connect. It may take up to an hour to refresh the alerts and make them visible. After waiting a reasonable amount of time, if you are still not seeing the yellow bar in the Dependency Graph, you may want to contact your administrator. In the mean time, to move along with the course, we'll give you a hint - the recommended upgraded version is `2.6.9`._
31+
1. Click the **Insights** tab in your repository
32+
1. On the left hand navigation bar, click **Dependency graph**
33+
1. Scroll down until you see a yellow bar highlighting the dependency named `debug`, and click on the right hand side of the yellow `debug` section
34+
1. Take note of the suggested version
35+
1. Comment in this issue with the suggested update version
3936

4037
For a printable version of the steps in this course, check out the [Quick Reference Guide]({{ host }}/public/{{ course.slug }}.pdf).
4138

4239
<hr>
43-
<h3 align="center">Return to this issue for my next comment.</h3>
40+
<h3 align="center">Return to this issue for my next comment</h3>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
Nice work!
22

33
<hr>
4-
<h3 align="center">I've opened a <a href="{{ repoUrl }}/pull/1">pull request with your next steps.</a></h3>
4+
<h3 align="center">I've opened <a href="{{ url }}">a pull request with your next steps</a></h3>

responses/03_good-pr.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ Great job, @{{ user.username }}, your pull request looks good. Thank you for fix
55
_Note: You might notice that this repository has a `package.json` file, but no `package-lock.json` file. We are doing all parts of this activity on GitHub.com. If you work with other repositories, you might notice some differences. Regardless of what dependency files you use, the main concepts of this course still apply._
66

77
### :keyboard: Activity: Merge
8-
1. Merge this pull request.
8+
1. Merge this pull request

responses/03_update-dependency.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Now that you know the recommended version, it's time to edit the `package.json`
1010

1111
### :keyboard: Activity: Update the `package.json` file
1212

13-
1. Within this pull request, go to **Files changed**.
14-
1. Click the pencil in the right upper corner to edit the `package.json` file.
15-
1. Fix the vulnerability by updating to the latest version of the dependency that you took note of earlier.
16-
1. Scroll down, and commit your change.
13+
1. Within this pull request, go to **Files changed**
14+
1. Click the pencil in the right upper corner to edit the `package.json` file
15+
1. Fix the vulnerability by updating to the latest version of the dependency that you took note of earlier
16+
1. Scroll down, and commit your change

responses/04a_good-merge.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
Nice job merging @{{ user.username }}. Go ahead and delete the branch.
22

33
<hr>
4-
<h3 align="center">Let's learn about <code>.gitignore</code> files in the <a href="{{ repoUrl }}/pull/3">next pull request.</a></h3>
4+
<h3 align="center">Let's learn about <code>.gitignore</code> files in the <a href="{{ url }}">next pull request</a></h3>

responses/04b_add-gitignore.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ In this pull request, I'm adding a `.gitignore` file. Files ending with `.env` c
1414

1515
### :keyboard: Activity: Updating the .gitignore file
1616

17-
1. Within this pull request, go to **Files changed**.
18-
1. Click the pencil in the right upper corner to edit the `.gitignore` file.
19-
1. Edit the file by adding `.env` to line 1.
20-
1. Scroll down, and commit your change.
17+
1. Within this pull request, go to **Files changed**
18+
1. Click the pencil in the right upper corner to edit the `.gitignore` file
19+
1. Edit the file by adding `.env` to line 1
20+
1. Scroll down, and commit your change
2121

2222
> _Note: Even after adding a file to the `.gitignore`, the previous commits that have edited that file still exist. If you accidentally committed sensitive data, first change any tokens or passwords. Then, contact GitHub Support for help correcting your history._
2323
2424
For a printable version of the steps in this course, check out the [Quick Reference Guide]({{ host }}/public/{{ course.slug }}.pdf).
2525

2626
<hr>
27-
<h3 align="center">Return to this pull request for my next comment.</h3>
27+
<h3 align="center">Return to this pull request for my next comment</h3>
2828

2929
> _Sometimes I respond too fast for the page to update! If you perform an expected action and don't see a response from me, wait a few seconds. Then refresh the page for your next steps._

responses/05_good-ignore.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
This looks great @{{ user.username }}, thanks for adding a `.env` file to the `.gitignore`. Feel free to add any other file or potential sensitive data to the `.gitignore` file.
44

55
### :keyboard: Activity: Merge
6-
1. Merge this pull request.
6+
1. Merge this pull request

0 commit comments

Comments
 (0)