Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Commit 5710ca2

Browse files
authored
Merge pull request #36 from githubtraining/sugg-changes
Update notes to show suggested changes should now work
2 parents 58038d6 + cac8095 commit 5710ca2

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

server-installation-notes.md

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,16 @@
11
## GitHub Enterprise Server (GHES) installation notes
22

3-
⚠️ | This course uses features not yet supported by GHES.
3+
| This course is fully compatible GHES version 2.17.4 or higher.
44
--- | ---
55

6-
This course makes use of [suggested changes](https://github.blog/changelog/2018-10-16-suggested-changes/), a feature that is currently in beta for GitHub.com but not available on GHES. **The course will still work**, but suggested changes will appear as pull request comments with the syntax:
7-
8-
```suggestion
9-
A suggestion
10-
```
6+
*Supported versions of GHES are visible by using the drop-down in the [official documentation](https://help.github.com/enterprise/).*
117

128
### Course dependencies
139

1410
The following are dependencies of the course. The course may continue to work without these dependencies, but learners won't experience the course as designed.
1511

16-
| Dependency | Required? | Reason | Alternative |
17-
|--------------------------------------------------------------------------------------------------------------------------|-----------|--------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
18-
| GHES must be able to reach githubusercontent.com | Yes | Images used throughout the course are served from this domain. Learners will find broken images required to take the course without this access. | Manually download the images referenced in the `responses/` folder, upload them to an accessible domain, and replace the images in the `responses/` folder. |
19-
| Learner must be able to reach github.com and outside web | No | Links are provided to resources that live on the outside web. | Without access to resources on the outside web, learners will reach blocked resources. You can change the links to these resources in the `responses/` folder, and in the template repository. |
12+
| Dependency | Required? | Reason | Alternative |
13+
|-------------------- | ------------------------|--------------|------------ |
14+
| GHES v2.17.4 | No | This course makes use of [suggested changes](https://github.blog/changelog/2018-10-16-suggested-changes/) which were released in v2.17.4 | **The course will still work**, but suggested changes will appear as pull request comments |
15+
| GHES must be able to reach githubusercontent.com | Yes | Images used throughout the course are served from this domain. Learners will find broken images required to take the course without this access. | Manually download the images referenced in the `responses/` folder, upload them to an accessible domain, and replace the images in the `responses/` folder. |
16+
| Learner must be able to reach github.com and outside web | No | Links are provided to resources that live on the outside web. | Without access to resources on the outside web, learners will reach blocked resources. You can change the links to these resources in the `responses/` folder, and in the template repository. |

0 commit comments

Comments
 (0)