Prevent middle-click from closing unclosable tabs (#372)

BenHetherington · web-flow · commit 1abe101ef762 · 2021-11-16T06:24:39.000+01:00
This fixes a bug whereby you could close a dock widget by middle-clicking its tab, even if its `CDockWidget::DockWidgetClosable` flag is set to `false`.
diff --git a/src/DockWidgetTab.cpp b/src/DockWidgetTab.cpp
@@ -407,7 +407,7 @@ void CDockWidgetTab::mouseReleaseEvent(QMouseEvent* ev)
 	} 
 	else if (ev->button() == Qt::MiddleButton)
 	{
-		if (CDockManager::testConfigFlag(CDockManager::MiddleMouseButtonClosesTab))
+		if (CDockManager::testConfigFlag(CDockManager::MiddleMouseButtonClosesTab) && dockWidget->features().testFlag(CDockWidget::DockWidgetClosable))
 		{
 			// Only attempt to close if the mouse is still
 			// on top of the widget, to allow the user to cancel.

Original file line number	Diff line number	Diff line change
`@@ -407,7 +407,7 @@ void CDockWidgetTab::mouseReleaseEvent(QMouseEvent* ev)`
`407`	`407`	`}`
`408`	`408`	`else if (ev->button() == Qt::MiddleButton)`
`409`	`409`	`{`
`410`		`- if (CDockManager::testConfigFlag(CDockManager::MiddleMouseButtonClosesTab))`
	`410`	`+ if (CDockManager::testConfigFlag(CDockManager::MiddleMouseButtonClosesTab) && dockWidget->features().testFlag(CDockWidget::DockWidgetClosable))`
`411`	`411`	`{`
`412`	`412`	`// Only attempt to close if the mouse is still`
`413`	`413`	`// on top of the widget, to allow the user to cancel.`