Skip to content

Commit a65b1bd

Browse files
Removed new dropped signals
1 parent 4041aa7 commit a65b1bd

File tree

5 files changed

+11
-34
lines changed

5 files changed

+11
-34
lines changed

src/DockContainerWidget.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1464,7 +1464,7 @@ void CDockContainerWidget::dropFloatingWidget(CFloatingDockContainer* FloatingWi
14641464
if (SingleDroppedDockWidget)
14651465
{
14661466
std::cout << "SingleDockWidget dropped" << std::endl;
1467-
d->DockManager->notifyWidgetDrop(SingleDroppedDockWidget);
1467+
d->DockManager->notifyWidgetOrAreaRelocation(SingleDroppedDockWidget);
14681468
}
14691469
d->DockManager->notifyFloatingWidgetDrop(FloatingWidget);
14701470
}
@@ -1499,7 +1499,7 @@ void CDockContainerWidget::dropWidget(QWidget* Widget, DockWidgetArea DropArea,
14991499
}
15001500

15011501
window()->activateWindow();
1502-
d->DockManager->notifyWidgetDrop(Widget);
1502+
d->DockManager->notifyWidgetOrAreaRelocation(Widget);
15031503
}
15041504

15051505

src/DockManager.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -530,6 +530,7 @@ void DockManagerPrivate::updateDockWidgetFocus(CDockWidget* DockWidget)
530530
auto NewFloatingWidget = FocusedDockWidget->dockContainer()->floatingWidget();
531531
if (NewFloatingWidget)
532532
{
533+
std::cout << "NewFloatingWidget->setProperty(FocusedDockWidget)" << std::endl;
533534
NewFloatingWidget->setProperty("FocusedDockWidget", QVariant::fromValue(DockWidget));
534535
}
535536

@@ -1076,15 +1077,14 @@ void CDockManager::onFocusedDockAreaViewToggled(bool Open)
10761077

10771078

10781079
//===========================================================================
1079-
void CDockManager::notifyWidgetDrop(QWidget* DroppedWidget)
1080+
void CDockManager::notifyWidgetOrAreaRelocation(QWidget* DroppedWidget)
10801081
{
10811082
std::cout << "\n\nCDockManager::notifyWidgetDrop" << std::endl;
10821083
CDockWidget* DockWidget = qobject_cast<CDockWidget*>(DroppedWidget);
10831084
if (DockWidget)
10841085
{
10851086
std::cout << "CDockManager::setWidgetFocus " << DockWidget->objectName().toStdString() << std::endl;
10861087
CDockManager::setWidgetFocus(DockWidget->tabWidget());
1087-
emit dockWidgetDropped(DockWidget);
10881088
return;
10891089
}
10901090

src/DockManager.h

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ private slots:
126126
* A container needs to call this function if a widget has been dropped
127127
* into it
128128
*/
129-
void notifyWidgetDrop(QWidget* DroppedWidget);
129+
void notifyWidgetOrAreaRelocation(QWidget* RelocatedWidget);
130130

131131
/**
132132
* This function is called, if a floating widget has been dropped into
@@ -517,18 +517,6 @@ public slots:
517517
* docking system but it is not deleted yet.
518518
*/
519519
void dockWidgetRemoved(CDockWidget* DockWidget);
520-
521-
/**
522-
* This signal is emitted if a dock widget has been dropped into a new
523-
* position
524-
*/
525-
void dockWidgetDropped(CDockWidget* DockWidget);
526-
527-
/**
528-
* This signal is emitted if a dock area has been dropped into a new
529-
* position
530-
*/
531-
void dockAreaDropped(CDockAreaWidget* DockArea);
532520
}; // class DockManager
533521
} // namespace ads
534522
//-----------------------------------------------------------------------------

src/DockWidgetTab.cpp

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -466,24 +466,9 @@ void CDockWidgetTab::setActiveTab(bool active)
466466
bool AllTabsHaveCloseButton = d->testConfigFlag(CDockManager::AllTabsHaveCloseButton);
467467
bool TabHasCloseButton = (ActiveTabHasCloseButton && active) | AllTabsHaveCloseButton;
468468
d->CloseButton->setVisible(DockWidgetClosable && TabHasCloseButton);
469-
470-
if (CDockManager::configFlags().testFlag(CDockManager::FocusStyling))
469+
if (d->IsActiveTab == active)
471470
{
472-
bool UpdateFocusStyle = false;
473-
if (active && !hasFocus())
474-
{
475-
setFocus(Qt::OtherFocusReason);
476-
UpdateFocusStyle = true;
477-
}
478-
479-
if (d->IsActiveTab == active)
480-
{
481-
if (UpdateFocusStyle)
482-
{
483-
updateStyle();
484-
}
485-
return;
486-
}
471+
return;
487472
}
488473

489474
d->IsActiveTab = active;

src/FloatingDockContainer.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -637,6 +637,8 @@ CFloatingDockContainer::CFloatingDockContainer(CDockAreaWidget *DockArea) :
637637
{
638638
TopLevelDockWidget->emitTopLevelChanged(true);
639639
}
640+
641+
d->DockManager->notifyWidgetOrAreaRelocation(DockArea);
640642
}
641643

642644
//============================================================================
@@ -652,6 +654,8 @@ CFloatingDockContainer::CFloatingDockContainer(CDockWidget *DockWidget) :
652654
{
653655
TopLevelDockWidget->emitTopLevelChanged(true);
654656
}
657+
658+
d->DockManager->notifyWidgetOrAreaRelocation(DockWidget);
655659
}
656660

657661
//============================================================================

0 commit comments

Comments
 (0)