Skip to content

Commit 075fb41

Browse files
committed
feat: migrate to primer design tokens
Signed-off-by: Adam Setch <[email protected]>
1 parent 2b7ac4f commit 075fb41

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+4592
-4210
lines changed

src/renderer/components/AllRead.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,14 @@ import { Stack } from '@primer/react';
55
import { AppContext } from '../context/App';
66
import { Constants } from '../utils/constants';
77
import { hasFiltersSet } from '../utils/filters';
8-
import { Centered } from './primitives/Centered';
8+
import { Centered } from './layout/Centered';
99
import { EmojiText } from './primitives/EmojiText';
1010

11-
export const AllRead: FC = () => {
11+
interface IAllRead {
12+
fullHeight?: boolean;
13+
}
14+
15+
export const AllRead: FC<IAllRead> = ({ fullHeight = true }: IAllRead) => {
1216
const { settings } = useContext(AppContext);
1317

1418
const hasFilters = hasFiltersSet(settings);
@@ -22,7 +26,7 @@ export const AllRead: FC = () => {
2226
);
2327

2428
return (
25-
<Centered>
29+
<Centered fullHeight={fullHeight}>
2630
<Stack direction="vertical" align="center">
2731
<div className="mt-2 mb-5 text-5xl">
2832
<EmojiText text={emoji} />

src/renderer/components/Oops.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,22 @@ import { type FC, useMemo } from 'react';
22

33
import { Stack } from '@primer/react';
44
import type { GitifyError } from '../types';
5-
import { Centered } from './primitives/Centered';
5+
import { Centered } from './layout/Centered';
66
import { EmojiText } from './primitives/EmojiText';
77

88
interface IOops {
99
error: GitifyError;
10+
fullHeight?: boolean;
1011
}
1112

12-
export const Oops: FC<IOops> = ({ error }: IOops) => {
13+
export const Oops: FC<IOops> = ({ error, fullHeight = true }: IOops) => {
1314
const emoji = useMemo(
1415
() => error.emojis[Math.floor(Math.random() * error.emojis.length)],
1516
[error],
1617
);
1718

1819
return (
19-
<Centered>
20+
<Centered fullHeight={fullHeight}>
2021
<Stack direction="vertical" align="center">
2122
<div className="mt-2 text-5xl">
2223
<EmojiText text={emoji} />

src/renderer/components/__snapshots__/AllRead.test.tsx.snap

Lines changed: 40 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/components/__snapshots__/Oops.test.tsx.snap

Lines changed: 20 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
import { render } from '@testing-library/react';
2+
import { Centered } from './Centered';
3+
4+
describe('renderer/components/layout/Centered.tsx', () => {
5+
it('should render itself & its children - full height true', () => {
6+
const tree = render(<Centered fullHeight={true}>Test</Centered>);
7+
8+
expect(tree).toMatchSnapshot();
9+
});
10+
11+
it('should render itself & its children - full height false', () => {
12+
const tree = render(<Centered fullHeight={false}>Test</Centered>);
13+
14+
expect(tree).toMatchSnapshot();
15+
});
16+
});
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
import { Stack } from '@primer/react';
2+
import type { FC, ReactNode } from 'react';
3+
4+
interface ICentered {
5+
children: ReactNode;
6+
fullHeight?: boolean;
7+
}
8+
9+
export const Centered: FC<ICentered> = ({
10+
fullHeight = true,
11+
...props
12+
}: ICentered) => {
13+
return (
14+
<Stack
15+
direction={'vertical'}
16+
align={'center'}
17+
justify={'center'}
18+
padding={'spacious'}
19+
className={fullHeight && 'min-h-screen'}
20+
>
21+
{props.children}
22+
</Stack>
23+
);
24+
};

src/renderer/components/primitives/Contents.test.tsx renamed to src/renderer/components/layout/Contents.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { render } from '@testing-library/react';
22
import { Contents } from './Contents';
33

4-
describe('renderer/components/primitives/Contents.tsx', () => {
4+
describe('renderer/components/layout/Contents.tsx', () => {
55
it('should render itself & its children', () => {
66
const tree = render(<Contents>Test</Contents>);
77

File renamed without changes.

src/renderer/components/primitives/Page.test.tsx renamed to src/renderer/components/layout/Page.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { render } from '@testing-library/react';
22
import { Page } from './Page';
33

4-
describe('renderer/components/primitives/Page.tsx', () => {
4+
describe('renderer/components/layout/Page.tsx', () => {
55
it('should render itself & its children', () => {
66
const tree = render(<Page id="test">Test</Page>);
77

File renamed without changes.

0 commit comments

Comments
 (0)