Fix tests & remove underscore

Author: manosim

package.json

@@ -85,8 +85,7 @@
     "redux-storage-decorator-filter": "=1.1.8",
     "redux-storage-engine-localstorage": "=1.1.4",
     "redux-storage-merger-immutablejs": "=1.0.5",
-    "redux-thunk": "=2.2.0",
-    "underscore": "=1.8.3"
+    "redux-thunk": "=2.2.0"
   },
   "devDependencies": {
     "babel-eslint": "=7.2.3",

src/js/__tests__/routes/__snapshots__/notifications.js.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`routes/notification.js should render itself & its children 1`] = `
+exports[`routes/notification.js should render itself & its children (with notifications) 1`] = `
 <div
   className="container-fluid main-container notifications"
 >

src/js/__tests__/routes/notifications.js

@@ -1,6 +1,7 @@
 import React from 'react'; // eslint-disable-line no-unused-vars
-import { Map } from 'immutable';
+import { List, Map } from 'immutable';
 import renderer from 'react-test-renderer';
+import { shallow } from 'enzyme';
 
 import { NotificationsRoute, mapStateToProps } from '../../routes/notifications';
 import { mockedNotificationsRecuderData } from '../../__mocks__/mockedData';
@@ -10,7 +11,8 @@ jest.mock('../../components/notifications');
 describe('routes/notification.js', () => {
   const props = {
     failed: false,
-    accountNotifications: mockedNotificationsRecuderData
+    accountNotifications: mockedNotificationsRecuderData,
+    hasNotifications: true,
   };
 
   it('should test the mapStateToProps method', () => {
@@ -25,13 +27,43 @@ describe('routes/notification.js', () => {
 
     expect(mappedProps.failed).toBeFalsy();
     expect(mappedProps.accountNotifications).toEqual(mockedNotificationsRecuderData);
+    expect(mappedProps.hasNotifications).toBeTruthy();
   });
 
-  it('should render itself & its children', () => {
+  it('should render itself & its children (with notifications)', () => {
     const tree = renderer.create(
       <NotificationsRoute {...props} />
     );
 
     expect(tree).toMatchSnapshot();
   });
+
+  it('should render itself & its children (all read notifications)', () => {
+    const caseProps = {
+      ...props,
+      hasNotifications: false,
+      accountNotifications: List(),
+    };
+
+    const wrapper = shallow(
+      <NotificationsRoute {...caseProps} />
+    );
+
+    expect(wrapper).toBeDefined();
+    expect(wrapper.find('AllRead')).toHaveLength(1);
+  });
+
+  it('should render itself & its children (error page - oops)', () => {
+    const caseProps = {
+      ...props,
+      failed: true,
+    };
+
+    const wrapper = shallow(
+      <NotificationsRoute {...caseProps} />
+    );
+
+    expect(wrapper).toBeDefined();
+    expect(wrapper.find('Oops')).toHaveLength(1);
+  });
 });

src/js/components/all-read.js

@@ -1,4 +1,3 @@
-import _ from 'underscore';
 import React from 'react';
 import malarkey from 'malarkey';
 import {emojify} from 'react-emojione';
@@ -7,7 +6,9 @@ import constants from '../utils/constants';
 
 export default class AllRead extends React.PureComponent {
   componentDidMount() {
-    const message = _.sample(constants.ALLREAD_MESSAGES);
+    const message = constants.ALLREAD_MESSAGES[
+      Math.floor(Math.random() * constants.ALLREAD_MESSAGES.length)
+    ];
 
     const elem = document.querySelector('.typed');
     const opts = {
@@ -20,7 +21,9 @@ export default class AllRead extends React.PureComponent {
   }
 
   render() {
-    const emoji = _.sample(constants.ALLREAD_EMOJIS);
+    const emoji = constants.ALLREAD_EMOJIS[
+      Math.floor(Math.random() * constants.ALLREAD_EMOJIS.length)
+    ];
 
     return (
       <div className="container-fluid main-container notifications all-read">

src/js/components/oops.js

@@ -1,12 +1,14 @@
-import _ from 'underscore';
 import React from 'react';
 import {emojify} from 'react-emojione';
 
 import constants from '../utils/constants';
 
 export default class Oops extends React.PureComponent {
   render() {
-    const emoji = _.sample(constants.ERROR_EMOJIS);
+    const emoji = constants.ERROR_EMOJIS[
+      Math.floor(Math.random() * constants.ERROR_EMOJIS.length)
+    ];
+
 
     return (
       <div className="container-fluid main-container notifications errored">