Skip to content

Commit 145de6f

Browse files
committed
temp comment out all sx
Signed-off-by: Adam Setch <[email protected]>
1 parent 4ff877c commit 145de6f

File tree

8 files changed

+53
-39
lines changed

8 files changed

+53
-39
lines changed

src/renderer/components/Sidebar.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export const Sidebar: FC = () => {
6969
return getNotificationCount(notifications);
7070
}, [notifications]);
7171

72-
const sidebarButtonStyle = { color: 'white' };
72+
// const sidebarButtonStyle = { color: 'white' };
7373

7474
return (
7575
<Stack
@@ -102,7 +102,7 @@ export const Sidebar: FC = () => {
102102
icon={BellIcon}
103103
onClick={() => openGitHubNotifications(primaryAccountHostname)}
104104
size="small"
105-
sx={sidebarButtonStyle}
105+
// sx={sidebarButtonStyle}
106106
tooltipDirection="e"
107107
unsafeDisableTooltip={false}
108108
variant={notificationsCount > 0 ? 'primary' : 'invisible'}
@@ -116,7 +116,7 @@ export const Sidebar: FC = () => {
116116
icon={FilterIcon}
117117
onClick={() => toggleFilters()}
118118
size="small"
119-
sx={sidebarButtonStyle}
119+
// sx={sidebarButtonStyle}
120120
tooltipDirection="e"
121121
unsafeDisableTooltip={false}
122122
variant={hasActiveFilters(settings) ? 'primary' : 'invisible'}
@@ -129,7 +129,7 @@ export const Sidebar: FC = () => {
129129
icon={IssueOpenedIcon}
130130
onClick={() => openGitHubIssues(primaryAccountHostname)}
131131
size="small"
132-
sx={sidebarButtonStyle}
132+
// sx={sidebarButtonStyle}
133133
tooltipDirection="e"
134134
unsafeDisableTooltip={false}
135135
variant="invisible"
@@ -141,7 +141,7 @@ export const Sidebar: FC = () => {
141141
icon={GitPullRequestIcon}
142142
onClick={() => openGitHubPulls(primaryAccountHostname)}
143143
size="small"
144-
sx={sidebarButtonStyle}
144+
// sx={sidebarButtonStyle}
145145
tooltipDirection="e"
146146
unsafeDisableTooltip={false}
147147
variant="invisible"
@@ -165,7 +165,7 @@ export const Sidebar: FC = () => {
165165
loading={status === 'loading'}
166166
onClick={() => refreshNotifications()}
167167
size="small"
168-
sx={sidebarButtonStyle}
168+
// sx={sidebarButtonStyle}
169169
tooltipDirection="e"
170170
unsafeDisableTooltip={false}
171171
variant="invisible"
@@ -177,7 +177,7 @@ export const Sidebar: FC = () => {
177177
icon={GearIcon}
178178
onClick={() => toggleSettings()}
179179
size="small"
180-
sx={sidebarButtonStyle}
180+
// sx={sidebarButtonStyle}
181181
tooltipDirection="e"
182182
unsafeDisableTooltip={false}
183183
variant="invisible"
@@ -192,7 +192,7 @@ export const Sidebar: FC = () => {
192192
icon={XCircleIcon}
193193
onClick={() => quitApp()}
194194
size="small"
195-
sx={sidebarButtonStyle}
195+
// sx={sidebarButtonStyle}
196196
tooltipDirection="e"
197197
unsafeDisableTooltip={false}
198198
variant="invisible"

src/renderer/components/filters/SearchFilterSuggestions.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,9 @@ export const SearchFilterSuggestions: FC<SearchFilterSuggestionsProps> = ({
3737

3838
return (
3939
<Popover open>
40-
<Popover.Content sx={{ p: 2, mt: 2, width: '100%' }}>
40+
<Popover.Content
41+
// sx={{ p: 2, mt: 2, width: '100%' }}
42+
>
4143
<Stack direction="vertical" gap="condensed">
4244
{suggestions.length > 0 &&
4345
suggestions.map((q) => (

src/renderer/components/primitives/Title.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,11 @@ export const Title: FC<ITitle> = ({ size = 2, ...props }) => {
2525
id={`title-${name}`}
2626
>
2727
<props.icon size="small" />
28-
<Heading sx={{ fontSize: size }}>{props.children}</Heading>
28+
<Heading
29+
// sx={{ fontSize: size }}
30+
>
31+
{props.children}
32+
</Heading>
2933
{props.tooltip && (
3034
<Tooltip
3135
name={`tooltip-${name}`}

src/renderer/components/settings/SettingsReset.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export const SettingsReset: FC = () => {
3232
<Button
3333
data-testid="settings-reset"
3434
onClick={handleReset}
35-
sx={{ width: '200px' }}
35+
// sx={{ width: '200px' }}
3636
variant="danger"
3737
>
3838
Reset Settings

src/renderer/routes/Login.tsx

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,16 @@ export const LoginRoute: FC = () => {
4040
<LogoIcon isDark size={Size.LARGE} />
4141

4242
<Stack align="center" gap="none">
43-
<Heading sx={{ fontSize: 4 }}>GitHub Notifications</Heading>
44-
<Heading sx={{ fontSize: 3 }}>on your menu bar</Heading>
43+
<Heading
44+
// sx={{ fontSize: 4 }}
45+
>
46+
GitHub Notifications
47+
</Heading>
48+
<Heading
49+
// sx={{ fontSize: 3 }}
50+
>
51+
on your menu bar
52+
</Heading>
4553
</Stack>
4654

4755
<Stack align="center" gap="condensed">

src/renderer/routes/LoginWithOAuthApp.tsx

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,11 @@ export const LoginWithOAuthAppRoute: FC = () => {
172172
name="hostname"
173173
onChange={handleInputChange}
174174
placeholder="github.com"
175-
sx={{
176-
borderColor: errors.hostname
177-
? 'danger.emphasis'
178-
: 'border.default',
179-
}}
175+
// sx={{
176+
// borderColor: errors.hostname
177+
// ? 'danger.emphasis'
178+
// : 'border.default',
179+
// }}
180180
value={formData.hostname}
181181
/>
182182
</FormControl>
@@ -205,11 +205,11 @@ export const LoginWithOAuthAppRoute: FC = () => {
205205
name="clientId"
206206
onChange={handleInputChange}
207207
placeholder="Your generated client id (20 characters)"
208-
sx={{
209-
borderColor: errors.clientId
210-
? 'danger.emphasis'
211-
: 'border.default',
212-
}}
208+
// sx={{
209+
// borderColor: errors.clientId
210+
// ? 'danger.emphasis'
211+
// : 'border.default',
212+
// }}
213213
value={formData.clientId}
214214
/>
215215
</FormControl>
@@ -222,11 +222,11 @@ export const LoginWithOAuthAppRoute: FC = () => {
222222
name="clientSecret"
223223
onChange={handleInputChange}
224224
placeholder="Your generated client secret (40 characters)"
225-
sx={{
226-
borderColor: errors.clientSecret
227-
? 'danger.emphasis'
228-
: 'border.default',
229-
}}
225+
// sx={{
226+
// borderColor: errors.clientSecret
227+
// ? 'danger.emphasis'
228+
// : 'border.default',
229+
// }}
230230
trailingAction={
231231
<TextInput.Action
232232
aria-label={maskToken ? 'Show token' : 'Hide token'}

src/renderer/routes/LoginWithPersonalAccessToken.tsx

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,11 @@ export const LoginWithPersonalAccessTokenRoute: FC = () => {
163163
name="hostname"
164164
onChange={handleInputChange}
165165
placeholder="github.com"
166-
sx={{
167-
borderColor: errors.hostname
168-
? 'danger.emphasis'
169-
: 'border.default',
170-
}}
166+
// sx={{
167+
// borderColor: errors.hostname
168+
// ? 'danger.emphasis'
169+
// : 'border.default',
170+
// }}
171171
value={formData.hostname}
172172
/>
173173
</FormControl>
@@ -210,11 +210,11 @@ export const LoginWithPersonalAccessTokenRoute: FC = () => {
210210
name="token"
211211
onChange={handleInputChange}
212212
placeholder="Your generated token (40 characters)"
213-
sx={{
214-
borderColor: errors.token
215-
? 'danger.emphasis'
216-
: 'border.default',
217-
}}
213+
// sx={{
214+
// borderColor: errors.token
215+
// ? 'danger.emphasis'
216+
// : 'border.default',
217+
// }}
218218
trailingAction={
219219
<TextInput.Action
220220
aria-label={maskClientSecret ? 'Show token' : 'Hide token'}

src/renderer/utils/theme.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type { ColorModeWithAuto } from '@primer/react/lib/ThemeProvider';
1+
import type { ColorModeWithAuto } from '@primer/react/dist/ThemeProvider';
22

33
import { Theme } from '../types';
44

0 commit comments

Comments
 (0)