fix sonar issues

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/utils/notifications/handlers/checkSuite.ts

@@ -63,26 +63,25 @@ export const checkSuiteHandler = new CheckSuiteHandler();
 export function getCheckSuiteAttributes(
   notification: Notification,
 ): CheckSuiteAttributes | null {
-  const regexPattern =
+  const regex =
     /^(?<workflowName>.*?) workflow run(, Attempt #(?<attemptNumber>\d+))? (?<statusDisplayName>.*?) for (?<branchName>.*?) branch$/;
 
-  const matches = regexPattern.exec(notification.subject.title);
+  const match = regex.exec(notification.subject.title);
 
-  if (matches) {
-    const { groups } = matches;
-
-    return {
-      workflowName: groups.workflowName,
-      attemptNumber: groups.attemptNumber
-        ? Number.parseInt(groups.attemptNumber)
-        : null,
-      status: getCheckSuiteStatus(groups.statusDisplayName),
-      statusDisplayName: groups.statusDisplayName,
-      branchName: groups.branchName,
-    };
+  if (!match?.groups) {
+    return null;
   }
 
-  return null;
+  const { workflowName, attemptNumber, statusDisplayName, branchName } =
+    match.groups;
+
+  return {
+    workflowName,
+    attemptNumber: attemptNumber ? Number.parseInt(attemptNumber) : null,
+    status: getCheckSuiteStatus(statusDisplayName),
+    statusDisplayName,
+    branchName,
+  };
 }
 
 function getCheckSuiteStatus(statusDisplayName: string): CheckSuiteStatus {

src/renderer/utils/notifications/handlers/workflowRun.ts

@@ -46,22 +46,22 @@ export const workflowRunHandler = new WorkflowRunHandler();
 export function getWorkflowRunAttributes(
   notification: Notification,
 ): WorkflowRunAttributes | null {
-  const regexPattern =
+  const regex =
     /^(?<user>.*?) requested your (?<statusDisplayName>.*?) to deploy to an environment$/;
 
-  const matches = regexPattern.exec(notification.subject.title);
+  const match = regex.exec(notification.subject.title);
 
-  if (matches) {
-    const { groups } = matches;
-
-    return {
-      user: groups.user,
-      status: getWorkflowRunStatus(groups.statusDisplayName),
-      statusDisplayName: groups.statusDisplayName,
-    };
+  if (!match?.groups) {
+    return null;
   }
 
-  return null;
+  const { user, statusDisplayName } = match.groups;
+
+  return {
+    user: user,
+    status: getWorkflowRunStatus(statusDisplayName),
+    statusDisplayName: statusDisplayName,
+  };
 }
 
 function getWorkflowRunStatus(statusDisplayName: string): CheckSuiteStatus {