Skip to content

Commit 1e2da98

Browse files
committed
fix app layout dom order
Signed-off-by: Adam Setch <[email protected]>
1 parent bc143a1 commit 1e2da98

File tree

6 files changed

+32
-31
lines changed

6 files changed

+32
-31
lines changed

src/renderer/components/__snapshots__/Sidebar.test.tsx.snap

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/components/icons/LogoIcon.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@ export const LogoIcon: FC<ILogoIcon> = ({
2424
...props
2525
}: ILogoIcon) => (
2626
<svg
27+
aria-hidden="true"
2728
aria-label={`${APPLICATION.NAME} Logo`}
2829
className={cn(
2930
size === Size.SMALL && 'size-5',
3031
size === Size.MEDIUM && 'size-10',
3132
size === Size.LARGE && 'size-16',
3233
)}
3334
onClick={() => onClick?.()}
34-
role="img"
3535
viewBox="0 0 500 500"
3636
xmlns="https://www.w3.org/2000/svg"
3737
xmlnsXlink="https://www.w3.org/1999/xlink"

src/renderer/components/icons/__snapshots__/LogoIcon.test.tsx.snap

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/components/layout/AppLayout.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,10 @@ interface IAppLayout {
1313
export const AppLayout: FC<IAppLayout> = ({ children }) => {
1414
return (
1515
<div className="flex flex-col min-h-screen bg-gitify-background">
16-
<Sidebar />
17-
{/* Content area with left padding to make space for the sidebar */}
16+
{/* Content first in DOM so initial focus won't land on sidebar buttons */}
1817
<div className="flex-1 pl-sidebar">{children}</div>
18+
19+
<Sidebar />
1920
</div>
2021
);
2122
};

src/renderer/components/layout/__snapshots__/AppLayout.test.tsx.snap

Lines changed: 12 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/routes/__snapshots__/Login.test.tsx.snap

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)