feat(api): codegen for discussions

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/utils/notifications/handlers/discussion.test.ts

@@ -7,7 +7,7 @@ import {
 } from '../../../__mocks__/notifications-mocks';
 import { mockSettings } from '../../../__mocks__/state-mocks';
 import type { Link } from '../../../types';
-import type { Repository } from '../../../typesGitHub';
+import type { Owner, Repository } from '../../../typesGitHub';
 import {
   type AuthorFieldsFragment,
   type Discussion,
@@ -24,11 +24,13 @@ const mockDiscussionAuthor: AuthorFieldsFragment = {
 
 describe('renderer/utils/notifications/handlers/discussion.ts', () => {
   describe('enrich', () => {
+    const partialOwner: Partial<Owner> = {
+      login: 'gitify-app',
+    };
+
     const partialRepository: Partial<Repository> = {
       full_name: 'gitify-app/notifications-test',
-      owner: {
-        login: 'gitify-app',
-      } as any,
+      owner: partialOwner as Owner,
     };
 
     const mockNotification = createPartialMockNotification({
@@ -244,17 +246,18 @@ describe('renderer/utils/notifications/handlers/discussion.ts', () => {
       mockDiscussion.labels = {
         nodes: [
           {
-            id: 'MDU6TGFiZWwxMQ==',
             name: 'enhancement',
           },
         ],
-      } as unknown as typeof mockDiscussion.labels;
+      } as Partial<Discussion>['labels'];
       nock('https://api.github.com')
         .post('/graphql')
         .reply(200, {
           data: {
             repository: {
-              discussion: mockDiscussion,
+              discussion: {
+                ...mockDiscussion,
+              },
             },
           },
         });
@@ -325,26 +328,20 @@ describe('renderer/utils/notifications/handlers/discussion.ts', () => {
 });
 
 function mockDiscussionNode(
-  state: DiscussionStateReason | null,
+  state: DiscussionStateReason,
   isAnswered: boolean,
 ): Partial<Discussion> {
   return {
     number: 123,
     title: 'This is a mock discussion',
     url: 'https://github.com/gitify-app/notifications-test/discussions/1' as Link,
-    stateReason: state || undefined,
+    stateReason: state,
     isAnswered: isAnswered,
     author: mockDiscussionAuthor,
     comments: {
       nodes: [],
       totalCount: 0,
-      pageInfo: {
-        hasNextPage: false,
-        hasPreviousPage: false,
-        startCursor: null,
-        endCursor: null,
-      },
-    } as unknown as Partial<Discussion>['comments'],
-    labels: null as Partial<Discussion>['labels'],
+    },
+    labels: null,
   } as unknown as Partial<Discussion>;
 }

src/renderer/utils/notifications/handlers/discussion.ts

@@ -124,32 +124,23 @@ export function getClosestDiscussionCommentOrReply(
     return null;
   }
 
-  const targetDate = notification.updated_at;
+  const targetTimestamp = notification.updated_at;
 
   const allCommentsAndReplies = comments.flatMap((comment) => [
     comment,
     ...comment.replies.nodes,
   ]);
 
-  // Consider only comments with a databaseId so we can anchor the URL
-  const commentsWithIds = allCommentsAndReplies.filter(
-    (item) => item?.databaseId != null,
-  );
-
-  if (commentsWithIds.length === 0) {
-    return null;
-  }
-
   // Find the closest match using the target timestamp
-  const closestComment = commentsWithIds.reduce((prev, curr) => {
+  const closestComment = allCommentsAndReplies.reduce((prev, curr) => {
     const prevDiff = Math.abs(
-      differenceInMilliseconds(prev.createdAt, targetDate),
+      differenceInMilliseconds(prev.createdAt, targetTimestamp),
     );
     const currDiff = Math.abs(
-      differenceInMilliseconds(curr.createdAt, targetDate),
+      differenceInMilliseconds(curr.createdAt, targetTimestamp),
     );
     return currDiff < prevDiff ? curr : prev;
-  }, commentsWithIds[0]);
+  }, allCommentsAndReplies[0]);
 
   return closestComment;
 }