feat: search notifications

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/components/filters/SearchFilterSuggestions.tsx

@@ -5,7 +5,8 @@ import { Box, Popover, Stack, Text } from '@primer/react';
 import { Opacity } from '../../types';
 import { cn } from '../../utils/cn';
 import {
-  getAvailableSearchQualifiers,
+  BASE_QUALIFIERS,
+  QUALIFIERS,
   SEARCH_DELIMITER,
 } from '../../utils/notifications/filters/search';
 
@@ -27,7 +28,7 @@ export const SearchFilterSuggestions: FC<SearchFilterSuggestionsProps> = ({
   }
 
   const lower = inputValue.toLowerCase();
-  const base = getAvailableSearchQualifiers(isDetailedNotificationsEnabled);
+  const base = isDetailedNotificationsEnabled ? QUALIFIERS : BASE_QUALIFIERS;
   const suggestions = base.filter(
     (q) => q.prefix.startsWith(lower) || inputValue === '',
   );

src/renderer/utils/notifications/filters/filter.ts

@@ -5,33 +5,34 @@ import type {
   SubjectUser,
 } from '../../../typesGitHub';
 import {
-  AUTHOR_PREFIX,
   filterNotificationBySearchTerm,
   hasExcludeSearchFilters,
   hasIncludeSearchFilters,
-  ORG_PREFIX,
-  REPO_PREFIX,
   reasonFilter,
-  type SearchPrefix,
   stateFilter,
   subjectTypeFilter,
   userTypeFilter,
+  type SearchQualifier,
+  BASE_QUALIFIERS,
+  DETAILED_ONLY_QUALIFIERS,
 } from '.';
 
+
+
 export function filterBaseNotifications(
   notifications: Notification[],
   settings: SettingsState,
 ): Notification[] {
   return notifications.filter((notification) => {
     let passesFilters = true;
 
-    passesFilters =
-      passesFilters &&
-      passesSearchTokenFiltersForPrefix(notification, settings, ORG_PREFIX);
-
-    passesFilters =
-      passesFilters &&
-      passesSearchTokenFiltersForPrefix(notification, settings, REPO_PREFIX);
+    // Apply base qualifier include/exclude filters (org, repo, etc.)
+    for (const qualifier of BASE_QUALIFIERS) {
+      if (!passesFilters) break;
+      passesFilters =
+        passesFilters &&
+        passesSearchTokenFiltersForQualifier(notification, settings, qualifier);
+    }
 
     if (subjectTypeFilter.hasFilters(settings)) {
       passesFilters =
@@ -86,12 +87,13 @@ export function hasAnyFiltersSet(settings: SettingsState): boolean {
 /**
  * Apply include/exclude search token logic for a specific search qualifier prefix.
  */
-function passesSearchTokenFiltersForPrefix(
+function passesSearchTokenFiltersForQualifier(
   notification: Notification,
   settings: SettingsState,
-  prefix: SearchPrefix,
+  qualifier: SearchQualifier,
 ): boolean {
   let passes = true;
+  const prefix = qualifier.prefix;
 
   if (hasIncludeSearchFilters(settings)) {
     const includeTokens = settings.filterIncludeSearchTokens.filter((t) =>
@@ -136,10 +138,13 @@ function passesUserFilters(
       );
   }
 
-  // Apply author-specific search token filters during detailed filtering
-  passesFilters =
-    passesFilters &&
-    passesSearchTokenFiltersForPrefix(notification, settings, AUTHOR_PREFIX);
+  // Apply detailed-only qualifier search token filters (e.g. author)
+  for (const qualifier of DETAILED_ONLY_QUALIFIERS) {
+    if (!passesFilters) break;
+    passesFilters =
+      passesFilters &&
+      passesSearchTokenFiltersForQualifier(notification, settings, qualifier);
+  }
 
   return passesFilters;
 }

src/renderer/utils/notifications/filters/search.ts

@@ -25,14 +25,24 @@ const SEARCH_QUALIFIERS = {
   },
 } as const;
 
-type SearchQualifierKey = keyof typeof SEARCH_QUALIFIERS;
-type SearchQualifier = (typeof SEARCH_QUALIFIERS)[SearchQualifierKey];
+export type SearchQualifierKey = keyof typeof SEARCH_QUALIFIERS;
+export type SearchQualifier = (typeof SEARCH_QUALIFIERS)[SearchQualifierKey];
 export type SearchPrefix = SearchQualifier['prefix'];
 
 export const QUALIFIERS: readonly SearchQualifier[] = Object.values(
   SEARCH_QUALIFIERS,
 ) as readonly SearchQualifier[];
 
+
+// Pre-split qualifier sets so we don't filter each time for every notification
+export const BASE_QUALIFIERS: readonly SearchQualifier[] = QUALIFIERS.filter(
+  (q) => !q.requiresDetailsNotifications,
+);
+
+export const DETAILED_ONLY_QUALIFIERS: readonly SearchQualifier[] = QUALIFIERS.filter(
+  (q) => q.requiresDetailsNotifications,
+);
+
 export const AUTHOR_PREFIX: SearchPrefix = SEARCH_QUALIFIERS.author.prefix;
 export const ORG_PREFIX: SearchPrefix = SEARCH_QUALIFIERS.org.prefix;
 export const REPO_PREFIX: SearchPrefix = SEARCH_QUALIFIERS.repo.prefix;