Skip to content

Commit 45e75e7

Browse files
committed
fix small ui issues
Signed-off-by: Adam Setch <[email protected]>
1 parent 7459698 commit 45e75e7

File tree

6 files changed

+342
-311
lines changed

6 files changed

+342
-311
lines changed

src/renderer/components/Sidebar.tsx

Lines changed: 28 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,10 @@ export const Sidebar: FC = () => {
8181
padding="normal"
8282
>
8383
<IconButton
84-
aria-label="Home"
8584
icon={LogoIcon}
85+
aria-label="Gitify"
86+
description="Home"
87+
unsafeDisableTooltip={false}
8688
size="small"
8789
variant="invisible"
8890
tooltipDirection="e"
@@ -91,45 +93,56 @@ export const Sidebar: FC = () => {
9193
/>
9294

9395
<IconButton
94-
aria-label={`${notificationsCount} unread notifications`}
9596
icon={BellIcon}
97+
aria-label="Notifications"
98+
description={`${notificationsCount} unread notifications`}
99+
unsafeDisableTooltip={false}
96100
size="small"
97101
variant={notificationsCount > 0 ? 'primary' : 'invisible'}
98102
tooltipDirection="e"
99103
onClick={() => openGitHubNotifications(primaryAccountHostname)}
100104
data-testid="sidebar-notifications"
105+
sx={{ color: 'white' }}
101106
/>
102107

103108
{/* TODO - explore https://primer.style/components/selectpanel/react/alpha/ for a better UI for filters */}
104109
{isLoggedIn && (
105110
<IconButton
106-
aria-label="Filter notifications"
107111
icon={FilterIcon}
112+
aria-label="Filters"
113+
description="Filter notifications"
114+
unsafeDisableTooltip={false}
108115
size="small"
109116
variant={filterCount > 0 ? 'primary' : 'invisible'}
110117
tooltipDirection="e"
111118
onClick={() => toggleFilters()}
112119
data-testid="sidebar-filter-notifications"
120+
sx={{ color: 'white' }}
113121
/>
114122
)}
115123

116124
<IconButton
117-
aria-label="My issues"
118125
icon={IssueOpenedIcon}
126+
aria-label="My issues"
127+
unsafeDisableTooltip={false}
119128
size="small"
120129
variant="invisible"
121130
tooltipDirection="e"
122131
onClick={() => openGitHubIssues(primaryAccountHostname)}
123132
data-testid="sidebar-my-issues"
133+
sx={{ color: 'white' }}
124134
/>
135+
125136
<IconButton
126-
aria-label="My pull requests"
127137
icon={GitPullRequestIcon}
138+
aria-label="My pull requests"
139+
unsafeDisableTooltip={false}
128140
size="small"
129141
variant="invisible"
130142
tooltipDirection="e"
131143
onClick={() => openGitHubPulls(primaryAccountHostname)}
132144
data-testid="sidebar-my-pull-requests"
145+
sx={{ color: 'white' }}
133146
/>
134147
</Stack>
135148
</div>
@@ -143,38 +156,45 @@ export const Sidebar: FC = () => {
143156
{isLoggedIn && (
144157
<>
145158
<IconButton
146-
aria-label="Refresh notifications"
147159
icon={SyncIcon}
160+
aria-label="Refresh"
161+
description="Refresh notifications"
162+
unsafeDisableTooltip={false}
148163
size="small"
149164
variant="invisible"
150165
tooltipDirection="e"
151166
loading={status === 'loading'}
152167
disabled={status === 'loading'}
153168
onClick={() => refreshNotifications()}
154169
data-testid="sidebar-refresh"
170+
sx={{ color: 'white' }}
155171
/>
156172

157173
<IconButton
158-
aria-label="Settings"
159174
icon={GearIcon}
175+
aria-label="Settings"
176+
unsafeDisableTooltip={false}
160177
size="small"
161178
variant="invisible"
162179
tooltipDirection="e"
163180
onClick={() => toggleSettings()}
164181
data-testid="sidebar-settings"
182+
sx={{ color: 'white' }}
165183
/>
166184
</>
167185
)}
168186

169187
{!isLoggedIn && (
170188
<IconButton
171-
aria-label="Quit Gitify"
172189
icon={XCircleIcon}
190+
aria-label="Quit Gitify"
191+
unsafeDisableTooltip={false}
173192
size="small"
174193
variant="invisible"
175194
tooltipDirection="e"
176195
onClick={() => quitApp()}
177196
data-testid="sidebar-quit"
197+
sx={{ color: 'white' }}
178198
/>
179199
)}
180200
</Stack>

0 commit comments

Comments
 (0)