Skip to content

Commit 49c230a

Browse files
committed
incorporate feedback: border red on error
Signed-off-by: Adam Setch <[email protected]>
1 parent 8baa2a8 commit 49c230a

File tree

4 files changed

+18
-13
lines changed

4 files changed

+18
-13
lines changed

src/renderer/components/fields/FieldInput.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import type { FC, ReactNode } from 'react';
22
import { Field } from 'react-final-form';
3+
import { cn } from '../../utils/cn';
34

45
export interface IFieldInput {
56
name: string;
@@ -31,7 +32,11 @@ export const FieldInput: FC<IFieldInput> = ({
3132

3233
<input
3334
type={type}
34-
className="mb-2 block w-full appearance-none rounded border border-red-500 bg-gray-100 px-4 py-1.5 text-sm focus:bg-gray-200 focus:outline-none dark:text-gray-800"
35+
className={cn(
36+
'mb-2 block w-full appearance-none',
37+
'rounded border bg-gray-100 px-4 py-1.5 text-sm focus:bg-gray-200 focus:outline-none dark:text-gray-800',
38+
error ? 'border-red-500' : 'border-gray-500',
39+
)}
3540
id={input.name}
3641
placeholder={placeholder}
3742
required={required}

src/renderer/components/fields/__snapshots__/FieldInput.test.tsx.snap

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/routes/__snapshots__/LoginWithOAuthApp.test.tsx.snap

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/routes/__snapshots__/LoginWithPersonalAccessToken.test.tsx.snap

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)