feat(filter): avoid further enrichment if state not visible

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/utils/notifications/filters/filter.ts

@@ -70,7 +70,7 @@ export function filterDetailedNotifications(
       }
 
       passesFilters =
-        passesFilters && isNotificationStateVisible(notification, settings);
+        passesFilters && passesStateFilter(notification, settings);
     }
 
     return passesFilters;
@@ -88,7 +88,7 @@ export function hasAnyFiltersSet(settings: SettingsState): boolean {
   );
 }
 
-function isNotificationStateVisible(
+function passesStateFilter(
   notification: Notification,
   settings: SettingsState,
 ): boolean {
@@ -101,11 +101,11 @@ function isNotificationStateVisible(
   return true;
 }
 
-export function wouldStateBeHiddenByFilters(
+export function isStateFilteredOut(
   state: StateType,
   settings: SettingsState,
 ): boolean {
   const notification = { subject: { state } } as Notification;
 
-  return !isNotificationStateVisible(notification, settings);
+  return !passesStateFilter(notification, settings);
 }

src/renderer/utils/subject.ts

@@ -25,7 +25,7 @@ import {
   getPullRequestReviews,
   getRelease,
 } from './api/client';
-import { wouldStateBeHiddenByFilters } from './notifications/filters/filter';
+import { isStateFilteredOut } from './notifications/filters/filter';
 
 export async function getGitifySubjectDetails(
   notification: Notification,
@@ -166,7 +166,7 @@ async function getGitifySubjectForDiscussion(
   }
 
   // Return early if this notification would be hidden by filters
-  if (wouldStateBeHiddenByFilters(discussionState, settings)) {
+  if (isStateFilteredOut(discussionState, settings)) {
     return null;
   }
 
@@ -225,7 +225,7 @@ async function getGitifySubjectForIssue(
   const issueState = issue.state_reason ?? issue.state;
 
   // Return early if this notification would be hidden by filters
-  if (wouldStateBeHiddenByFilters(issueState, settings)) {
+  if (isStateFilteredOut(issueState, settings)) {
     return null;
   }
 
@@ -269,7 +269,7 @@ async function getGitifySubjectForPullRequest(
   let prCommentUser: User;
 
   // Return early if this notification would be hidden by filters
-  if (wouldStateBeHiddenByFilters(prState, settings)) {
+  if (isStateFilteredOut(prState, settings)) {
     return null;
   }
   if (