fix: issues identified by sonar

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/components/fields/Checkbox.tsx

@@ -54,11 +54,11 @@ export const Checkbox: FC<ICheckbox> = ({
           <Tooltip name={`tooltip-${props.name}`} tooltip={props.tooltip} />
         )}
 
-        {counter && (
+        {counter ? (
           <CounterLabel scheme={props.checked ? 'primary' : 'secondary'}>
             {counter}
           </CounterLabel>
-        )}
+        ) : null}
       </Stack>
     )
   );

src/renderer/components/metrics/MetricPill.tsx

@@ -23,7 +23,9 @@ export const MetricPill: FC<IMetricPill> = (props: IMetricPill) => {
     >
       <Stack direction="horizontal" align="center" gap="none">
         <props.icon size={Size.XSMALL} className={props.color} />
-        {props.metric && <Text className="text-xxs px-1">{props.metric}</Text>}
+        {props.metric ? (
+          <Text className="text-xxs px-1">{props.metric}</Text>
+        ) : null}
       </Stack>
     </Label>
   );

src/renderer/utils/auth/utils.test.ts

@@ -101,7 +101,9 @@ describe('renderer/utils/auth/utils.ts', () => {
       });
 
       await expect(async () => await auth.authGitHub()).rejects.toEqual(
-        "Oops! Something went wrong and we couldn't log you in using GitHub. Please try again. Reason: The redirect_uri is missing or invalid. Docs: https://docs.github.com/en/developers/apps/troubleshooting-oauth-errors",
+        new Error(
+          "Oops! Something went wrong and we couldn't log you in using GitHub. Please try again. Reason: The redirect_uri is missing or invalid. Docs: https://docs.github.com/en/developers/apps/troubleshooting-oauth-errors",
+        ),
       );
 
       expect(openExternalLinkMock).toHaveBeenCalledTimes(1);

src/renderer/utils/auth/utils.ts

@@ -54,7 +54,9 @@ export function authGitHub(
         });
       } else if (error) {
         reject(
-          `Oops! Something went wrong and we couldn't log you in using GitHub. Please try again. Reason: ${errorDescription} Docs: ${errorUri}`,
+          new Error(
+            `Oops! Something went wrong and we couldn't log you in using GitHub. Please try again. Reason: ${errorDescription} Docs: ${errorUri}`,
+          ),
         );
       }
     };