feat(filter): avoid further enrichment if state not visible

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/utils/notifications/filters/filter.ts

@@ -69,13 +69,8 @@ export function filterDetailedNotifications(
           );
       }
 
-      if (stateFilter.hasFilters(settings)) {
-        passesFilters =
-          passesFilters &&
-          settings.filterStates.some((state) =>
-            stateFilter.filterNotification(notification, state),
-          );
-      }
+      passesFilters =
+        passesFilters && isNotificationStateVisible(notification, settings);
     }
 
     return passesFilters;
@@ -92,3 +87,16 @@ export function hasAnyFiltersSet(settings: SettingsState): boolean {
     reasonFilter.hasFilters(settings)
   );
 }
+
+export function isNotificationStateVisible(
+  notification: Notification,
+  settings: SettingsState,
+): boolean {
+  if (stateFilter.hasFilters(settings)) {
+    return settings.filterStates.some((state) =>
+      stateFilter.filterNotification(notification, state),
+    );
+  }
+
+  return true;
+}

src/renderer/utils/notifications/notifications.ts

@@ -108,7 +108,10 @@ export async function enrichNotifications(
       let additionalSubjectDetails: GitifySubject = {};
 
       try {
-        additionalSubjectDetails = await getGitifySubjectDetails(notification);
+        additionalSubjectDetails = await getGitifySubjectDetails(
+          notification,
+          settings,
+        );
       } catch (err) {
         logError(
           'enrichNotifications',