test: refactor render with app context

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/components/Sidebar.test.tsx

@@ -4,7 +4,6 @@ import { MemoryRouter } from 'react-router-dom';
 
 import { renderWithAppContext } from '../__helpers__/test-utils';
 import { mockAccountNotifications } from '../__mocks__/notifications-mocks';
-import { mockAuth, mockSettings } from '../__mocks__/state-mocks';
 import * as comms from '../utils/comms';
 import { Sidebar } from './Sidebar';
 

src/renderer/components/filters/FilterSection.test.tsx

@@ -33,7 +33,7 @@ describe('renderer/components/filters/FilterSection.tsx', () => {
           settings: {
             ...mockSettings,
             detailedNotifications: true,
-          } as SettingsState,
+          },
           notifications: mockAccountNotifications,
         },
       );
@@ -57,7 +57,7 @@ describe('renderer/components/filters/FilterSection.tsx', () => {
           settings: {
             ...mockSettings,
             detailedNotifications: false,
-          } as SettingsState,
+          },
           notifications: mockAccountNotifications,
         },
       );

src/renderer/components/filters/ReasonFilter.test.tsx

@@ -1,9 +1,12 @@
 import { renderWithAppContext } from '../../__helpers__/test-utils';
+import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
 import { ReasonFilter } from './ReasonFilter';
 
 describe('renderer/components/filters/ReasonFilter.tsx', () => {
   it('should render itself & its children', () => {
-    const tree = renderWithAppContext(<ReasonFilter />);
+    const tree = renderWithAppContext(<ReasonFilter />, {
+      notifications: mockAccountNotifications,
+    });
 
     expect(tree).toMatchSnapshot();
   });

src/renderer/components/filters/SearchFilter.test.tsx

@@ -14,7 +14,6 @@ describe('renderer/components/filters/SearchFilter.tsx', () => {
   describe('Include Search Tokens', () => {
     it('adds include actor token with prefix', () => {
       renderWithAppContext(<SearchFilter />, {
-        settings: mockSettings,
         updateFilter: mockUpdateFilter,
       });
 
@@ -31,7 +30,6 @@ describe('renderer/components/filters/SearchFilter.tsx', () => {
 
     it('adds include org token with prefix', () => {
       renderWithAppContext(<SearchFilter />, {
-        settings: mockSettings,
         updateFilter: mockUpdateFilter,
       });
 
@@ -48,7 +46,6 @@ describe('renderer/components/filters/SearchFilter.tsx', () => {
 
     it('adds include repo token with prefix', () => {
       renderWithAppContext(<SearchFilter />, {
-        settings: mockSettings,
         updateFilter: mockUpdateFilter,
       });
 
@@ -67,7 +64,6 @@ describe('renderer/components/filters/SearchFilter.tsx', () => {
 
     it('prevent unrecognized include prefixes', () => {
       renderWithAppContext(<SearchFilter />, {
-        settings: mockSettings,
         updateFilter: mockUpdateFilter,
       });
 
@@ -84,7 +80,6 @@ describe('renderer/components/filters/SearchFilter.tsx', () => {
   describe('Exclude Search Tokens', () => {
     it('adds exclude actor token with prefix', () => {
       renderWithAppContext(<SearchFilter />, {
-        settings: mockSettings,
         updateFilter: mockUpdateFilter,
       });
 
@@ -101,7 +96,6 @@ describe('renderer/components/filters/SearchFilter.tsx', () => {
 
     it('adds exclude org token with prefix', () => {
       renderWithAppContext(<SearchFilter />, {
-        settings: mockSettings,
         updateFilter: mockUpdateFilter,
       });
 
@@ -118,7 +112,6 @@ describe('renderer/components/filters/SearchFilter.tsx', () => {
 
     it('adds exclude repo token with prefix', () => {
       renderWithAppContext(<SearchFilter />, {
-        settings: mockSettings,
         updateFilter: mockUpdateFilter,
       });
 
@@ -137,7 +130,6 @@ describe('renderer/components/filters/SearchFilter.tsx', () => {
 
     it('prevent unrecognized exclude prefixes', () => {
       renderWithAppContext(<SearchFilter />, {
-        settings: mockSettings,
         updateFilter: mockUpdateFilter,
       });
 

src/renderer/components/filters/SearchFilterSuggestions.test.tsx

@@ -11,7 +11,7 @@ describe('renderer/components/filters/SearchFilterSuggestions.tsx', () => {
         settings: {
           ...mockSettings,
           detailedNotifications: false,
-        } as SettingsState,
+        },
       },
     );
 
@@ -25,7 +25,7 @@ describe('renderer/components/filters/SearchFilterSuggestions.tsx', () => {
         settings: {
           ...mockSettings,
           detailedNotifications: true,
-        } as SettingsState,
+        },
       },
     );
 
@@ -39,7 +39,7 @@ describe('renderer/components/filters/SearchFilterSuggestions.tsx', () => {
         settings: {
           ...mockSettings,
           detailedNotifications: true,
-        } as SettingsState,
+        },
       },
     );
 
@@ -53,7 +53,7 @@ describe('renderer/components/filters/SearchFilterSuggestions.tsx', () => {
         settings: {
           ...mockSettings,
           detailedNotifications: false,
-        } as SettingsState,
+        },
       },
     );
 
@@ -67,7 +67,7 @@ describe('renderer/components/filters/SearchFilterSuggestions.tsx', () => {
         settings: {
           ...mockSettings,
           detailedNotifications: false,
-        } as SettingsState,
+        },
       },
     );
 

src/renderer/components/filters/StateFilter.test.tsx

@@ -1,9 +1,12 @@
 import { renderWithAppContext } from '../../__helpers__/test-utils';
+import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
 import { StateFilter } from './StateFilter';
 
 describe('renderer/components/filters/StateFilter.tsx', () => {
   it('should render itself & its children', () => {
-    const tree = renderWithAppContext(<StateFilter />);
+    const tree = renderWithAppContext(<StateFilter />, {
+      notifications: mockAccountNotifications,
+    });
 
     expect(tree).toMatchSnapshot();
   });

src/renderer/components/filters/SubjectTypeFilter.test.tsx

@@ -1,9 +1,12 @@
 import { renderWithAppContext } from '../../__helpers__/test-utils';
+import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
 import { SubjectTypeFilter } from './SubjectTypeFilter';
 
 describe('renderer/components/filters/SubjectTypeFilter.tsx', () => {
   it('should render itself & its children', () => {
-    const tree = renderWithAppContext(<SubjectTypeFilter />);
+    const tree = renderWithAppContext(<SubjectTypeFilter />, {
+      notifications: mockAccountNotifications,
+    });
 
     expect(tree).toMatchSnapshot();
   });

src/renderer/components/filters/UserTypeFilter.test.tsx

@@ -1,16 +1,10 @@
 import { renderWithAppContext } from '../../__helpers__/test-utils';
 import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
-import { mockSettings } from '../../__mocks__/state-mocks';
-import type { SettingsState } from '../../types';
 import { UserTypeFilter } from './UserTypeFilter';
 
 describe('renderer/components/filters/UserTypeFilter.tsx', () => {
   it('should render itself & its children', () => {
     const tree = renderWithAppContext(<UserTypeFilter />, {
-      settings: {
-        ...mockSettings,
-        detailedNotifications: true,
-      } as SettingsState,
       notifications: mockAccountNotifications,
     });