Merge pull request #410 from codebytere/fix-subscription-ignore

fix: use thread subscription set endpoint

Author: manosim

src/js/actions/index.test.ts

@@ -379,7 +379,7 @@ describe('actions/index.js', () => {
 
     // The unsubscribe endpoint call.
     nock('https://api.github.com/')
-      .delete(`/notifications/threads/${id}/subscription`)
+      .put(`/notifications/threads/${id}/subscription`)
       .reply(204);
 
     // The mark read endpoint call.
@@ -419,7 +419,7 @@ describe('actions/index.js', () => {
     const message = 'Oops! Something went wrong.';
 
     nock('https://api.github.com/')
-      .delete(`/notifications/threads/${id}/subscription`)
+      .put(`/notifications/threads/${id}/subscription`)
       .reply(400, { message });
 
     const expectedActions = [

src/js/actions/index.ts

@@ -181,7 +181,7 @@ export function unsubscribeNotification(id, hostname) {
 
     dispatch({ type: UNSUBSCRIBE_NOTIFICATION.REQUEST });
 
-    return apiRequestAuth(unsubscribeURL, Methods.DELETE, token, {})
+    return apiRequestAuth(unsubscribeURL, Methods.PUT, token, { ignore: true })
       .then((response) => {
         // The GitHub notifications API doesn't automatically mark things as read
         // like it does in the UI, so after unsubscribing we also need to hit the