feat(accounts): warn when missing scopes

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/__mocks__/partial-mocks.ts

@@ -13,6 +13,7 @@ export function partialMockNotification(
       hostname: Constants.GITHUB_API_BASE_URL as Hostname,
       token: mockToken,
       user: mockGitifyUser,
+      hasRequiredScopes: true,
     },
     subject: subject as Subject,
   };

src/renderer/__mocks__/state-mocks.ts

@@ -43,6 +43,7 @@ export const mockOAuthAccount: Account = {
   token: '1234568790' as Token,
   hostname: 'github.gitify.io' as Hostname,
   user: mockGitifyUser,
+  hasRequiredScopes: true,
 };
 
 export const mockGitHubCloudAccount: Account = {
@@ -52,6 +53,7 @@ export const mockGitHubCloudAccount: Account = {
   hostname: Constants.DEFAULT_AUTH_OPTIONS.hostname,
   user: mockGitifyUser,
   version: 'latest',
+  hasRequiredScopes: true,
 };
 
 export const mockGitHubEnterpriseServerAccount: Account = {
@@ -60,6 +62,7 @@ export const mockGitHubEnterpriseServerAccount: Account = {
   token: '1234568790' as Token,
   hostname: 'github.gitify.io' as Hostname,
   user: mockGitifyUser,
+  hasRequiredScopes: true,
 };
 
 export const mockGitHubAppAccount: Account = {
@@ -68,6 +71,7 @@ export const mockGitHubAppAccount: Account = {
   token: '987654321' as Token,
   hostname: Constants.DEFAULT_AUTH_OPTIONS.hostname,
   user: mockGitifyUser,
+  hasRequiredScopes: true,
 };
 
 export const mockAuth: AuthState = {

src/renderer/routes/Accounts.tsx

@@ -102,23 +102,22 @@ export const AccountsRoute: FC = () => {
                     </span>
                   </button>
 
-                  {account.method === 'Personal Access Token' &&
-                    account.hasRequiredScopes === false && (
-                      <span className="text-xs font-medium italic">
-                        <button
-                          type="button"
-                          className="cursor-pointer"
-                          title={`This account is missing one or more required scopes: \n  - ${Constants.AUTH_SCOPE.join('\n  - ')}`}
-                          aria-label="missing-scopes"
-                          onClick={() => openDeveloperSettings(account)}
-                        >
-                          <AlertFillIcon
-                            size={Size.XSMALL}
-                            className={IconColor.RED}
-                          />
-                        </button>
-                      </span>
-                    )}
+                  {account.hasRequiredScopes === false && (
+                    <span className="text-xs font-medium italic">
+                      <button
+                        type="button"
+                        className="cursor-pointer"
+                        title={`This account is missing one or more required scopes: \n  - ${Constants.AUTH_SCOPE.join('\n  - ')}`}
+                        aria-label="missing-scopes"
+                        onClick={() => openDeveloperSettings(account)}
+                      >
+                        <AlertFillIcon
+                          size={Size.XSMALL}
+                          className={IconColor.RED}
+                        />
+                      </button>
+                    </span>
+                  )}
                 </div>
                 <div>
                   <button